On Fri, Oct 25, 2024 at 02:08:13PM +0200, Stefano Brivio wrote:
> /home/sbrivio/passt/udp.c:171:1: error: inital values in enum 'udp_iov_idx' are not consistent, consider explicit initialization of all, none or only the first enumerator [cert-int09-c,readability-enum-initial-value,-warnings-as-errors]
>   171 | enum udp_iov_idx {
>       | ^
>   172 |         UDP_IOV_TAP     = 0,
>   173 |         UDP_IOV_ETH     = 1,
>   174 |         UDP_IOV_IP      = 2,
>   175 |         UDP_IOV_PAYLOAD = 3,
>   176 |         UDP_NUM_IOVS
>       |
>       |                      = 4
> 
> Don't initialise any value, so that it's obvious that constants map to
> unique values.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  udp.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/udp.c b/udp.c
> index 100610f..0c01067 100644
> --- a/udp.c
> +++ b/udp.c
> @@ -169,11 +169,11 @@ udp_meta[UDP_MAX_FRAMES];
>   * @UDP_NUM_IOVS        the number of entries in the iovec array
>   */
>  enum udp_iov_idx {
> -	UDP_IOV_TAP	= 0,
> -	UDP_IOV_ETH	= 1,
> -	UDP_IOV_IP	= 2,
> -	UDP_IOV_PAYLOAD	= 3,
> -	UDP_NUM_IOVS
> +	UDP_IOV_TAP,
> +	UDP_IOV_ETH,
> +	UDP_IOV_IP,
> +	UDP_IOV_PAYLOAD,
> +	UDP_NUM_IOVS,
>  };
>  
>  /* IOVs and msghdr arrays for receiving datagrams from sockets */

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson