From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=VTCi0xk4; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id CDF065A004C for ; Fri, 18 Oct 2024 03:36:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1729215357; bh=yZ6Y22NZGwzysOTyPCzxTPQtwk7i35kFJHmMXHOxbt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VTCi0xk4BDrJQvDjpRaflA9/RYIHcWGRRLC3eKt9gfHwlGq9woodYU6/quVpY8vRp XcgUciM9JRpgydCe9HB4Sgx3UYNNQ1yS7VdcPnnxpqVyjDtUiM4qVQixdWiB+laBps GyM7uQzgSoPso2NzieVNnSSiTLIQw0yFpansxxJBdQxK/SFZTUYvLm/z9icErZ0Cf3 I/5CBtiEdZ3JtHf70cVVZPpvtp7TYj7uhiEg8FnB4p/PlY1IUaJLStI6XehCGnhtid 0vMveU97mLJ22Mi+otqZ0HWj7QMPtGoNzmkHx2ErYxlQMFmZmRC/C/JTgUlVU4w/e9 ChFSxhH9v+zMQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4XV6jT1S3cz4wbr; Fri, 18 Oct 2024 12:35:57 +1100 (AEDT) Date: Fri, 18 Oct 2024 12:13:27 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v4 3/7] test: Wait for DAD on DHCPv6 addresses Message-ID: References: <20241017053304.909386-1-david@gibson.dropbear.id.au> <20241017053304.909386-4-david@gibson.dropbear.id.au> <20241017104529.5a92aa31@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="27gUj9MY/ZvZakn1" Content-Disposition: inline In-Reply-To: <20241017104529.5a92aa31@elisabeth> Message-ID-Hash: H6JFSOK47QUQGJW6OMPWAYLO47GERMQ4 X-Message-ID-Hash: H6JFSOK47QUQGJW6OMPWAYLO47GERMQ4 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --27gUj9MY/ZvZakn1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 17, 2024 at 10:45:29AM +0200, Stefano Brivio wrote: > On Thu, 17 Oct 2024 16:33:00 +1100 > David Gibson wrote: >=20 > > After running dhclient -6 we expect the DHCPv6 assigned address to be > > immediately usable. That's true with the Fedora dhclient-script (and t= he > > upstream ISC DHCP one), however it's not true with the Debian > > dhclient-script. The Debian script can complete with the address still > > in "tentative" state, and the address won't be usable until Duplicate > > Address Detection (DAD) completes. That's arguably a bug in Debian (see > > link below), but for the time being we need to work around it anyway. > >=20 > > We usually get away with this, because by the time we do anything where= the > > address matters, DAD has completed. However, it's not robust, so we sh= ould > > explicitly wait for DAD to complete when we get an DHCPv6 address. > >=20 > > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1085231 > >=20 > > Signed-off-by: David Gibson > > --- > > test/passt/dhcp | 2 ++ > > test/pasta/dhcp | 2 ++ > > test/two_guests/basic | 3 +++ >=20 > What about the equivalent cases in passt_in_ns/dhcp and perf/passt_tcp? Oops, somehow I missed those. Will fix and respin. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --27gUj9MY/ZvZakn1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmcRtjYACgkQzQJF27ox 2Gd7rxAAoEOldDt4GEp4mWiD/5PAZ0iMKp62QALFoRMgLTYT/gpQrKcOkFrGDSbQ S3SSu16HF7ORqOpjitXk4UHw4Hzt1LZYuPbOMJvKT7pAtblsSWfKYlOPt2FbJPt4 93hwDdlMegL214NydncXhMHjXlKAx/RzETSaNB4CYzDEipGtQHolmvxg0hsv26kl oERjVkP9MkIuLzhSrwgAe7CXiHPZkp5HdaiixXDYPE9TqmKgbOoVomYSRNaSCc5Q PFfs8YhYkMIL6aYQ9Ao9oWgX+lCnGsiVWiLNtJpa9GLXAJgUcQVglGcR0Kwd6KYR Ya9+RNyLjpJo8GdKkyKjUoefRqmOGhumFkq/DXXstbUp+I3JyIEzY+2aogBqPQIs N6miMc5mZlBycbiPAimiU+OFX8Vl2Nwn3P7nfQDl8zU6ULjTveogpum3jb79gG/L qct2VX9IsJHp6BdUxz1S4HPA3d++Jx5Gt4CLJbesYcClxGZmecgQAkoRkZrRxfZJ nbw1s/hhu967hdNxedpCsiPpQUAvVgfXl5F6UzH1683/m2tadEX19qFZ0cGJD6l4 Pwjpf7A7PNVWRuknj+/7o93O0GgHP4oaxymCInVpcQT4L6hTHn6E3spi8IQDYm0m F48jMqbut46bKKKAZq4Q9Jfsden2CwKxTaGdsavX82/C2wgm7yU= =TuMr -----END PGP SIGNATURE----- --27gUj9MY/ZvZakn1--