Re: [PATCH 1/8] Makefile: Exclude qrap.c from clang-tidy checks

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]

On Fri, Oct 25, 2024 at 01:04:31AM +0200, Stefano Brivio wrote:
> We'll deprecate qrap(1) soon, and warnings reported by clang-tidy as
> of LLVM versions 16 and later would need a bunch of changes there to
> be addressed, mostly around CERT C rule ERR33-C and checking return
> code from snprintf().
> 
> It makes no sense to fix warnings in qrap just for the sake of it, so
> officially declare the bitrotting season open.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 74a9513..2ebc81e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -271,7 +271,7 @@ docs: README.md
>  #	weird for cases like standalone constants, and causes other
>  #	awkwardness for a bunch of cases we use
>  
> -clang-tidy: $(SRCS) $(HEADERS)
> +clang-tidy: $(filter-out qrap.c,$(SRCS)) $(HEADERS)
>  	clang-tidy -checks=*,-modernize-*,\
>  	-clang-analyzer-valist.Uninitialized,\
>  	-cppcoreguidelines-init-variables,\
> @@ -298,7 +298,7 @@ clang-tidy: $(SRCS) $(HEADERS)
>  	-misc-include-cleaner,\
>  	-cppcoreguidelines-macro-to-enum \
>  	-config='{CheckOptions: [{key: bugprone-suspicious-string-compare.WarnOnImplicitComparison, value: "false"}]}' \
> -	--warnings-as-errors=* $(SRCS) -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -DCLANG_TIDY_58992
> +	--warnings-as-errors=* $(filter-out qrap.c,$(SRCS)) -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -DCLANG_TIDY_58992
>  
>  SYSTEM_INCLUDES := /usr/include $(wildcard /usr/include/$(TARGET))
>  ifeq ($(shell $(CC) -v 2>&1 | grep -c "gcc version"),1)

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]