From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202410 header.b=C+B6dr4m; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id DA02B5A061A for ; Fri, 25 Oct 2024 02:52:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202410; t=1729817532; bh=EcZYdKZbKq2EXL9B8X944wY754/HSGaoHcGFhxzr0XI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C+B6dr4mef9+8lfBycNqYC0gBhqjBgGSTnO7BR75qwB8o2prc9DQsTu+3rE7FeLyZ DhzPN1CrYGHBLiSVTah+oW8+DwrOVVgk1RH9P3hi39WNCsiZk+JmU5mf8PW0EWO+Rj oaF32xPXpj/ltY7mUIA40pWPNX8z4NlnB5km15XYseTy/c2KRKc+zE6s0aDD8NJ8nq Z7C+0cFTYT0em8XoGdE6wy3/UzmdBErjd1Tg5tnW9matsoW/GNC/FAhThBM+1m2AID 170SzcQEHLoW5Qs3nLHl11lfZTt/0L07/ujGvX/d/5jGX8Dw7/aT3QaCAIm1krY64O vv9iBs0M32rLQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4XZPPm3Prsz4wyk; Fri, 25 Oct 2024 11:52:12 +1100 (AEDT) Date: Fri, 25 Oct 2024 11:35:08 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 1/8] Makefile: Exclude qrap.c from clang-tidy checks Message-ID: References: <20241024230438.3192725-1-sbrivio@redhat.com> <20241024230438.3192725-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tcDjo8zBvanJNfdN" Content-Disposition: inline In-Reply-To: <20241024230438.3192725-2-sbrivio@redhat.com> Message-ID-Hash: C2UQDKEAZS7ZPHBFCOP4UDWE6FXGQ4ZP X-Message-ID-Hash: C2UQDKEAZS7ZPHBFCOP4UDWE6FXGQ4ZP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --tcDjo8zBvanJNfdN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 25, 2024 at 01:04:31AM +0200, Stefano Brivio wrote: > We'll deprecate qrap(1) soon, and warnings reported by clang-tidy as > of LLVM versions 16 and later would need a bunch of changes there to > be addressed, mostly around CERT C rule ERR33-C and checking return > code from snprintf(). >=20 > It makes no sense to fix warnings in qrap just for the sake of it, so > officially declare the bitrotting season open. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/Makefile b/Makefile > index 74a9513..2ebc81e 100644 > --- a/Makefile > +++ b/Makefile > @@ -271,7 +271,7 @@ docs: README.md > # weird for cases like standalone constants, and causes other > # awkwardness for a bunch of cases we use > =20 > -clang-tidy: $(SRCS) $(HEADERS) > +clang-tidy: $(filter-out qrap.c,$(SRCS)) $(HEADERS) > clang-tidy -checks=3D*,-modernize-*,\ > -clang-analyzer-valist.Uninitialized,\ > -cppcoreguidelines-init-variables,\ > @@ -298,7 +298,7 @@ clang-tidy: $(SRCS) $(HEADERS) > -misc-include-cleaner,\ > -cppcoreguidelines-macro-to-enum \ > -config=3D'{CheckOptions: [{key: bugprone-suspicious-string-compare.War= nOnImplicitComparison, value: "false"}]}' \ > - --warnings-as-errors=3D* $(SRCS) -- $(filter-out -pie,$(FLAGS) $(CFLAGS= ) $(CPPFLAGS)) -DCLANG_TIDY_58992 > + --warnings-as-errors=3D* $(filter-out qrap.c,$(SRCS)) -- $(filter-out -= pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -DCLANG_TIDY_58992 > =20 > SYSTEM_INCLUDES :=3D /usr/include $(wildcard /usr/include/$(TARGET)) > ifeq ($(shell $(CC) -v 2>&1 | grep -c "gcc version"),1) --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --tcDjo8zBvanJNfdN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmca57sACgkQzQJF27ox 2GfYxw/8DKcXKPA6DnO4wyMBjc6RvV+A0PnzpggVGSrDwZK+rgtNeIBrZSR+D6hG GCc+KvELLtXL719IuCNX3NdLnBcq/95hDOYBJF604cmJVBLEEWQnaSD/lvjAtkYv l5m3s0k9akXeQyF82+yV2lADU3AGsyU0oVXoFYEBEkf50RbQJFhtfumvEM12TpIJ K/Se5n8jWvw307iwzwblp06RktAbjagkfYo/rfAIRlg/OZjauaYYUJv5ev8lx0jk dlsoO9SFH+aHgAbtZG6MHjXnMWVoR6BEys3ObgHrBSrsdD0xGYqvw359F9KvhgK8 gQ87Y+sf1bGBueyarDteLbkTeL+HRwUcsi6/gnAmhhaws8TfYp7DM2bw1jaR3THR wYE7OijF5qSpOiZof8c0nRoUhavkLegKb5WXLKc9LmPW5vjeTfvaLxpC+cKph2aL MtOSmUwOcuu7ThrMlAcGRcY60SVHIfLQnmTlIlRAKlE0ca82vdfgHJul1GAIHY34 n0KEaqnks/SGZu6UWxHYQqLJmneOtMwDQvqSu1h0N/FnwTA88YD8FvGIFS6tg+cC /t/Ft6Kd5OMzHwzBtw6Kf2EZU14Zh/SaLQGFy8h93tvpld1TAf/8jzlvVxzKd71K gvtKKRkopuHpf0nPjonT01Or3BYz9wAKE7ScI1PbECMzH0ybzXc= =0nXN -----END PGP SIGNATURE----- --tcDjo8zBvanJNfdN--