* [PATCH] tap: Explicitly cast TUNSETIFF to fix build warning with musl on ppc64le
@ 2024-10-30 20:50 Stefano Brivio
2024-10-31 0:33 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2024-10-30 20:50 UTC (permalink / raw)
To: passt-dev; +Cc: omni
On ppc64le, TUNSETIFF happens to be 2147767498, which is bigger than
INT_MAX (2^31 - 1), and musl declares the second argument of ioctl()
as 'int', not 'unsigned long' like glibc does, probably because of how
POSIX specifies the equivalent argument, int dcmd, in posix_devctl(),
so gcc reports a warning:
tap.c: In function 'tap_ns_tun':
tap.c:1291:24: warning: overflow in conversion from 'long unsigned int' to 'int' changes value from '2147767498' to '-2147199798' [-Woverflow]
1291 | rc = ioctl(fd, TUNSETIFF, &ifr);
| ^~~~~~~~~
We don't care about that overflow, so explicitly cast TUNSETIFF to
int.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tap.c b/tap.c
index cfb82e9..f638f2c 100644
--- a/tap.c
+++ b/tap.c
@@ -1288,7 +1288,7 @@ static int tap_ns_tun(void *arg)
if (fd < 0)
die_perror("Failed to open() /dev/net/tun");
- rc = ioctl(fd, TUNSETIFF, &ifr);
+ rc = ioctl(fd, (int)TUNSETIFF, &ifr);
if (rc < 0)
die_perror("TUNSETIFF ioctl on /dev/net/tun failed");
--
@@ -1288,7 +1288,7 @@ static int tap_ns_tun(void *arg)
if (fd < 0)
die_perror("Failed to open() /dev/net/tun");
- rc = ioctl(fd, TUNSETIFF, &ifr);
+ rc = ioctl(fd, (int)TUNSETIFF, &ifr);
if (rc < 0)
die_perror("TUNSETIFF ioctl on /dev/net/tun failed");
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tap: Explicitly cast TUNSETIFF to fix build warning with musl on ppc64le
2024-10-30 20:50 [PATCH] tap: Explicitly cast TUNSETIFF to fix build warning with musl on ppc64le Stefano Brivio
@ 2024-10-31 0:33 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2024-10-31 0:33 UTC (permalink / raw)
To: Stefano Brivio; +Cc: passt-dev, omni
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]
On Wed, Oct 30, 2024 at 09:50:30PM +0100, Stefano Brivio wrote:
> On ppc64le, TUNSETIFF happens to be 2147767498, which is bigger than
> INT_MAX (2^31 - 1), and musl declares the second argument of ioctl()
> as 'int', not 'unsigned long' like glibc does, probably because of how
> POSIX specifies the equivalent argument, int dcmd, in posix_devctl(),
> so gcc reports a warning:
>
> tap.c: In function 'tap_ns_tun':
> tap.c:1291:24: warning: overflow in conversion from 'long unsigned int' to 'int' changes value from '2147767498' to '-2147199798' [-Woverflow]
> 1291 | rc = ioctl(fd, TUNSETIFF, &ifr);
> | ^~~~~~~~~
>
> We don't care about that overflow, so explicitly cast TUNSETIFF to
> int.
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Ugly, but I don't see a better way to deal with it.
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> tap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tap.c b/tap.c
> index cfb82e9..f638f2c 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -1288,7 +1288,7 @@ static int tap_ns_tun(void *arg)
> if (fd < 0)
> die_perror("Failed to open() /dev/net/tun");
>
> - rc = ioctl(fd, TUNSETIFF, &ifr);
> + rc = ioctl(fd, (int)TUNSETIFF, &ifr);
> if (rc < 0)
> die_perror("TUNSETIFF ioctl on /dev/net/tun failed");
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-31 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-30 20:50 [PATCH] tap: Explicitly cast TUNSETIFF to fix build warning with musl on ppc64le Stefano Brivio
2024-10-31 0:33 ` David Gibson
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).