Re: [PATCH v10 07/12] vhost-user: add vhost-user

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

On Wed, Nov 13, 2024 at 08:13:43AM +0100, Laurent Vivier wrote:
> On 11/11/2024 03:47, David Gibson wrote:
> > > +			if (flow_sidx_valid(sidx)) {
> > > +				flow_sidx_t fromsidx = flow_sidx_opposite(sidx);
> > > +				struct udp_flow *uflow = udp_at_sidx(sidx);
> > > +
> > > +				flow_err(uflow,
> > > +					"No support for forwarding UDP from %s to %s",
> > > +					pif_name(pif_at_sidx(fromsidx)),
> > > +					pif_name(pif));
> > > +			} else {
> > > +				debug("Discarding 1 datagram without flow");
> > > +			}
> > > +
> > > +			continue;
> > > +		}
> > > +
> > > +		toside = flowside_at_sidx(sidx);
> > > +
> > > +		v6 = !(inany_v4(&toside->eaddr) && inany_v4(&toside->oaddr));
> > > +
> > > +		iov_used = udp_vu_sock_recv(c, ref.fd, events, v6, &dlen);
> > > +		if (iov_used <= 0)
> > > +			break;
> > > +
> > > +		udp_vu_prepare(c, toside, dlen);
> > > +		if (*c->pcap) {
> > > +			udp_vu_csum(toside, iov_used);
> > > +			pcap_iov(iov_vu, iov_used,
> > > +				 sizeof(struct virtio_net_hdr_mrg_rxbuf));
> > > +		}
> > > +		vu_flush(vdev, vq, elem, iov_used);
> > Do you really want to flush on every datagram?
> 
> To do like that avoids complexity in the code, but you're right it could be
> improved but I would prefer to do that once this series is merged with a
> follow up code. This kind of change is prone to introduce bugs...

Ok, fair enough.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]