From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 9BADB5A0082 for ; Thu, 16 Feb 2023 18:48:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676569700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7NdoRX/kyQVe2LTLQhRgTROmF3Op1Co46W+OthnwglM=; b=AoS6w+gSOfEeWeUQVeC81fcsJ2F9JXFTZZfbJAOaXhZqoWMJ6e+36hDTssNITN9ZR1iuDK nKUEYLhLwj/kNF00edkLQxmyx//a62PEqm2firF7/WAYVAr2mCnSVJHyIixmATTHU9D9S4 IvmBdbuNWO1yB5V/AqydwZHZT5PeLlE= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-499-501YVs9IMUmmqXMocb-ErQ-1; Thu, 16 Feb 2023 12:48:19 -0500 X-MC-Unique: 501YVs9IMUmmqXMocb-ErQ-1 Received: by mail-qt1-f199.google.com with SMTP id g9-20020ac80709000000b003ba266c0c2bso1619563qth.5 for ; Thu, 16 Feb 2023 09:48:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7NdoRX/kyQVe2LTLQhRgTROmF3Op1Co46W+OthnwglM=; b=dXodAXNagImjpT881LxxaNjbzK7YybQbl2vg/FAgnG2qCa+7PfcbkzoBrrdjGtJw6M PpVZvXAgSJdTu5Q+bs5phyQp9OPxVKeDGLqnMOSwwKYq/JdSGZBtpaLy7HyaIw35zaWh RTrQvV6NDdQHaOOqeserK2s/K9vE8/en8zxzno0uHTAnzQioy/t7ql/XmoJ+0C/TWPr4 GfOW9lSNuk4T63MHoPyYoDnv3HTNtz7dtA67j0mPHO+LUBjHPNAboRyjTtW0XHB5+ysw VV1joSptgvlrDCxMUFdlq6OvCcnqUKMi7FatNLCGPsxB++VR9toKMjS0tcbIipLzKqe1 ngMg== X-Gm-Message-State: AO0yUKVdSUa0Ny1OfHHcc71P0/GwfbsKX5MP5pFDpBsAVMHV2oYnXeWC d3Gj63a08qEE/i7SOK2ACQjkGNpZV1K2abMBiVvwVGTYbUmpQ6OQb/Biyud9VOwdDWsnnQStNPr /o7XOq/FX0db/Ft7ckZzk4roG975Tg71OiEDIKuMLk3Fy4aijfjhJKfpF3gg+eGJRGA== X-Received: by 2002:a05:622a:178c:b0:3b8:2a6c:d1e9 with SMTP id s12-20020a05622a178c00b003b82a6cd1e9mr12106917qtk.18.1676569698514; Thu, 16 Feb 2023 09:48:18 -0800 (PST) X-Google-Smtp-Source: AK7set9pIfxwGFnCmzcvihpSRZ1NnW+wnECc6eP1gH9SxD8dZ0RZb0U/R/KiPCUGVYWgjyR0xAwIRg== X-Received: by 2002:a05:622a:178c:b0:3b8:2a6c:d1e9 with SMTP id s12-20020a05622a178c00b003b82a6cd1e9mr12106881qtk.18.1676569698207; Thu, 16 Feb 2023 09:48:18 -0800 (PST) Received: from ?IPV6:2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7? ([2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7]) by smtp.gmail.com with ESMTPSA id e11-20020ac8010b000000b003b63a734434sm1647481qtg.52.2023.02.16.09.48.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 09:48:17 -0800 (PST) Message-ID: Date: Thu, 16 Feb 2023 12:48:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] passt.1: Fix typo, improve wording in examples of port forwarding specifiers To: passt-dev@passt.top References: <20230216072335.2238277-1-sbrivio@redhat.com> <96233b85-93de-6174-b64f-3655d9fb3642@redhat.com> <20230216183250.2442b366@elisabeth> From: Laine Stump Organization: Red Hat In-Reply-To: <20230216183250.2442b366@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: ZYKFQ4GZLYT2ZGOT23KKFOJ4ACIETLO4 X-Message-ID-Hash: ZYKFQ4GZLYT2ZGOT23KKFOJ4ACIETLO4 X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , Yalan Zhang , Stefano Brivio X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/16/23 12:32 PM, Stefano Brivio wrote: > On Thu, 16 Feb 2023 11:53:07 -0500 > Laine Stump wrote: > >> On 2/16/23 2:23 AM, Stefano Brivio wrote: >>> Based on a patch from Laine, and reports from Laine and Yalan: fix >>> the "22-80:32-90" example, and improve wording for the other ones: >>> instead of using "to" to denote the end of a range, use "between ... >>> and", so that it's clear we're *not* referring to target ports. >>> >>> Reported-by: Laine Stump >>> Reported-by: Yalan Zhang >>> Fixes: da20f57f19dc ("passt, qrap: Add man pages") >>> Signed-off-by: Stefano Brivio >> >> Reviewed-by: Laine Stump >> >> (if I'm allowed :-) > > Oops, not anymore, I'm in the middle of pushing things out and running > tests, I just pushed this, and I want to avoid rebasing the tree. > Oh, I wasn't talking about whether or not I "get documented credit for spending a few minutes looking at someone else's work". Just saying the equivalent of "Another set of eyes has looked at it and it seemed good", although I guess using the official rb header to do that may imply otherwise; that's just a force of habit :-)