From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id E3AED5A027A for ; Sat, 17 Feb 2024 15:22:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708179737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSQdUreQKcfLUAnUSS4VnLnWxbYHOhd42zcRM7EpQNw=; b=KENQQyCsfe5oEbOBoXnT04pyexUBjhCRm4I3cRVJNLGk5y6HWXumnzKHByFAXo4FExy6ka KCqYlty18MpS1ibbPVnuS8AmjAszxVBV1UUBLJn8JX7W944ZE4uV6R4CJLCY5oJVmAkdbN csS46HW6JmRMBFFGTpeP9rUSJtMDEp4= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-ostiV3NdP9CLAXZhU-dT5A-1; Sat, 17 Feb 2024 09:22:15 -0500 X-MC-Unique: ostiV3NdP9CLAXZhU-dT5A-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-42dbfd1fe8cso35486671cf.1 for ; Sat, 17 Feb 2024 06:22:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708179735; x=1708784535; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tSQdUreQKcfLUAnUSS4VnLnWxbYHOhd42zcRM7EpQNw=; b=gMCOH8nhq1V4u0zrkSc9r25aHiBmnA9yhF1cC8feq0K4s5fIv5aoltisCfhfl0lSqz cZJpPbPbSgFZ3AEg4nMVnYJCZ2NMGT87XrqzsMWpkCvy2dLwE2WI6By6jaSDmIDFVZgt MqqYheKz5Y74VAu89mtTjGGo7sxSRQ1jmK9SmVHaoryi7cyEPJN93gKXqAAM7iReBfoJ GOZOj2Wfc6LTY1s+Gx+WesJHt16axNhmDRQHYhCIoho0VfFcN0OSj0kaec6rqHcjrBJI xEDpGvZj9ppx3wa+mrRI5rxneA++97rql3ZSwNFnr9bwBUMWATCcbcn1g7hSbK319guM FClA== X-Gm-Message-State: AOJu0Yxyaz+TAqXITqWDPmNfSJyvsi0TMluzIp1ycXe7sV0wiog1++9y 6yGwp2xg5/O8nhT/uCyjIPjdxsDppDHC7S3JKAsSfOU7BeFhZbV/ucsRLaqYXmfkO1CoBz2alYI CnKtHDwORc65Rij6TupMHHry+MswIU0z3bvegGHilxTum/G9kZA== X-Received: by 2002:a05:6214:4107:b0:68c:7c27:fc83 with SMTP id kc7-20020a056214410700b0068c7c27fc83mr9062915qvb.18.1708179735048; Sat, 17 Feb 2024 06:22:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IHXaVgYOHnsLZiYoCAMLF8onksuip8XL7gAFSLDSs94s3ez3m/0xWIWMMqs3f0QAhQfbzFg4A== X-Received: by 2002:a05:6214:4107:b0:68c:7c27:fc83 with SMTP id kc7-20020a056214410700b0068c7c27fc83mr9062896qvb.18.1708179734669; Sat, 17 Feb 2024 06:22:14 -0800 (PST) Received: from [192.168.100.30] ([82.142.8.70]) by smtp.gmail.com with ESMTPSA id ks16-20020a056214311000b0068cea7fd1a1sm1063389qvb.27.2024.02.17.06.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Feb 2024 06:22:14 -0800 (PST) Message-ID: Date: Sat, 17 Feb 2024 15:22:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/8] checksum: use csum_ip4_header() in udp.c and tcp.c To: Stefano Brivio References: <20240214085628.210783-1-lvivier@redhat.com> <20240214085628.210783-7-lvivier@redhat.com> <20240216100805.040826b3@elisabeth> <53d4a403-0d3f-4aa0-b980-27c2026a468b@redhat.com> <20240216155400.1d26ae17@elisabeth> <7a9915cf-f004-453a-b328-80d086c14a80@redhat.com> <20240216192440.6031e2d2@elisabeth> From: Laurent Vivier In-Reply-To: <20240216192440.6031e2d2@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: XRRFTJV4XRF6CXNBDL4I7L4ANFLDKJIO X-Message-ID-Hash: XRRFTJV4XRF6CXNBDL4I7L4ANFLDKJIO X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/16/24 19:24, Stefano Brivio wrote: > On Fri, 16 Feb 2024 19:05:39 +0100 > Laurent Vivier wrote: > > ... >> I think I will send the v3 of my series without fixing that because I don't have enough >> time this week. I will address the problem later. > No problem! I will also try to spend a moment and see if there's some > reasonable solution I can suggest. Thanks, > I can imagine 4 solutions: * to use inline functions (could it helps the compiler to manage the alignment problem?) * to use C macros * to use these new functions only with vhost-user as we know pointers will be aligned. * to include structure we want to address in a generic wrapperstructure that will unalign it as it is done with the current structure. Thanks, Laurent