From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH v2] test: Display count of skipped tests in status and summary
Date: Wed, 14 May 2025 09:21:18 +0200 [thread overview]
Message-ID: <a3cff18e-296f-4470-9985-2fba9c7106c6@redhat.com> (raw)
In-Reply-To: <20250514071649.3540768-1-lvivier@redhat.com>
Sorry this version is not correct (forgot the commit amend...)
Correct v2 follows.
Laurent
On 14/05/2025 09:16, Laurent Vivier wrote:
> This commit enhances test reporting by tracking and displaying the
> number of skipped tests.
>
> The skipped test count is now visible in the tmux status bar during
> execution and included in the final test summary log. This provides
> a more complete overview of test suite results.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>
> Notes:
> v2: add missing comma before SKIPPED in report log
>
> test/lib/term | 7 +++++--
> test/run | 4 ++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/test/lib/term b/test/lib/term
> index ed690de82c20..089364c67f85 100755
> --- a/test/lib/term
> +++ b/test/lib/term
> @@ -19,6 +19,7 @@ STATUS_FILE_INDEX=0
> STATUS_COLS=
> STATUS_PASS=0
> STATUS_FAIL=0
> +STATUS_SKIPPED=0
>
> PR_RED='\033[1;31m'
> PR_GREEN='\033[1;32m'
> @@ -439,19 +440,21 @@ info_layout() {
> # status_test_ok() - Update counter of passed tests, log and display message
> status_test_ok() {
> STATUS_PASS=$((STATUS_PASS + 1))
> - tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | #(TZ="UTC" date -Iseconds)"
> + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)"
> info_passed
> }
>
> # status_test_fail() - Update counter of failed tests, log and display message
> status_test_fail() {
> STATUS_FAIL=$((STATUS_FAIL + 1))
> - tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | #(TZ="UTC" date -Iseconds)"
> + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)"
> info_failed
> }
>
> # status_test_fail() - Update counter of failed tests, log and display message
> status_test_skip() {
> + STATUS_SKIPPED=$((STATUS_SKIPPED + 1))
> + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)"
> info_skipped
> }
>
> diff --git a/test/run b/test/run
> index 4e86f30fb750..a6070d28e8c4 100755
> --- a/test/run
> +++ b/test/run
> @@ -202,7 +202,7 @@ skip_distro() {
> perf_finish
> [ ${CI} -eq 1 ] && video_stop
>
> - log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}"
> + log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL} SKIPPED: ${STATUS_SKIPPED}"
>
> pause_continue \
> "Press any key to keep test session open" \
> @@ -236,7 +236,7 @@ run_selected() {
> done
> teardown "${__setup}"
>
> - log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}"
> + log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL} SKIPPED: ${STATUS_SKIPPED}"
>
> pause_continue \
> "Press any key to keep test session open" \
next prev parent reply other threads:[~2025-05-14 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 7:16 [PATCH v2] test: Display count of skipped tests in status and summary Laurent Vivier
2025-05-14 7:21 ` Laurent Vivier [this message]
2025-05-14 7:20 Laurent Vivier
2025-05-14 9:51 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3cff18e-296f-4470-9985-2fba9c7106c6@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).