From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=vivier.eu Authentication-Results: passt.top; dkim=pass (2048-bit key; unprotected) header.d=vivier.eu header.i=laurent@vivier.eu header.a=rsa-sha256 header.s=s1-ionos header.b=tvm3tf+p; dkim-atps=neutral Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by passt.top (Postfix) with ESMTPS id 123B25A0265 for ; Tue, 24 Feb 2026 16:27:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivier.eu; s=s1-ionos; t=1771946819; x=1772551619; i=laurent@vivier.eu; bh=5KPbncPyL9uxYi+RQgctdxp+wzhMw2/OnV0FgbHfzzk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=tvm3tf+puaQ0POsMIIoXoV+0E1DyyfRUsCyzn1OWYTfA/Y3wZj2yt8h+M52G4Atq NvKsMRLjfsa0ihFCdOfZircUucgpN+x3xE2ZJw+zKEDsdLgGiHB2zN/rfR5PpOZf3 pr7AzFlYDvGv9tg2WcrC50zdiqeF5zEuC9DepbnirjBWTrL0Oy5fybc91NLFJNn3f IoKp7fiZWdeB9uGRI9kn06w9OwqOpwMneQxZgjiRxAoKoJU9R9madzsjGfFOGB4AK 23jAhJtlvvBQ2xsekmAdUQ66OCx7dXwWBVtL+K+PODeXbtw3ncL6el2f0cLdJsvtt yl5o4WYwtymQQ0wDZQ== X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from [192.168.1.24] ([92.153.144.197]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.168]) with ESMTPSA (Nemesis) id 1N5mWp-1vfdOa2gMF-00rpb9; Tue, 24 Feb 2026 16:26:59 +0100 Message-ID: Date: Tue, 24 Feb 2026 16:26:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH trivial] tcp_vu, udp_vu: Fix comment headers for header length functions To: Stefano Brivio , Laurent Vivier References: <20260224122227.437310-1-lvivier@redhat.com> <20260224162409.6ab5eb90@elisabeth> Content-Language: en-US From: Laurent Vivier In-Reply-To: <20260224162409.6ab5eb90@elisabeth> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:kWytLzZ21iz5g7B1THEznB3lENS+YA8u6o6tPVa0PaRw+2/RuFg lCSGJb4yxQfOTX7YFWQ6K5VG9nJSjHotZotrk9LNcGDD3pKjPzR1sTXjVy2+QJabGXEqoAD KdgJaGogozDjG9SC+wi4GLc8yKh5cWD6XhniwkxXlFEepC+C9u0lQxcTh/pkJDfuVqkoncC 6n3cmEqg2AJRWCwbVwjVQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:qh5EU/OFj7o=;GWj0vnChCIwtb6LE69i8QJMyzv4 L3YfT6qbu8PIHtEKOijHZZRUEPKiRCCeK2ieTioENLIxW7O5D6xVUKU9Xai8Qnk/Pwy2pUU2O MmE2CSjHb9YlxVwP7wlZQgurCukTF6RxSD3sFEcJGYPLmycfOoj81OkyK6EumdLVaGUzjG0h7 eqH8rNTNvePSyFv7Eum8FU4Xtmn2ZwPJ1AhFix6ZQtFI3UdcJV2c5sghbgudPztQ28q0DmXyi Gj/wC8/YB72wmS2x6N0zPo3KQkv4qQjUL5RK26EFx0Rozfs8KRm4lrl4cNi47YiYua5Swohtv Hn5IAKvqgMO6Bor0LNfwGfIvBIo3HmOBYowe9IT2eb2rUT0tIf+xpu3wcfhRTJdeiuVTSEfKC WpPo+cYUmugSCjbKc1czocUc9LmuRf5c3uSHyJmttzoPKYlp3u+6tCTKZTGXpYVzxxS27Uy7T FeV7qdEQ6BOQ7pmyJxg/MEwiD9iEs2W01QLEC2p4oycpLO4xhnrTDXClGEtOwgRWiBTBIVIrP sqsdQBJVrQ5obi/Tbkkx0jZj4x7myAeYQM0LSX63k6ceFk+Ns6Y4MBaV5oQxf4PGK1B4v0MoQ UlxVSptZCx4XdcOJqLknOvy9FNS57VTYKZHBc9tCfSzqCZIJ0GwIqc/02iGoLpLaYaxj3bJz9 RHY1xtaipEPiaxa5JbweZqHT+uhX95w8uPlIS53y8jiQR/06qjDRhnV97tvBmg1FNeO0PjTCC v2CLCIYUcOAVkGIqB6eDnyEY4pPb5rd1aO0sLrhxiQC/RHhro6kezDO3lqf4cGLWWjHteF4LI 98S+D+fNxgf8Fd76129+17+TseqQ195gea980BLQjUUFSCbfFVQ4n89LCLeDlfXvQ2zfY2Kth 6CfRb9Cnq6X8CpzpW5hlHeFfyWxj9Nd2KLWT+I5J5xHgLD6+hif2kmJPrT+WcepKjPg1vg6yp Vs1D5QuKkhsy9hxrjvD5Ja6hSYPfr4GmsjTb+d5EwdvDjTTQKYM4Lk2ksFvOTaimA+ixRg3Fw WWWb5d4RGUjFtBgxvNQBqfccOpLcBJWLsBgr9e7MT7P2JC+TlGoAL2+ZD1VuEo0LleOq51+aA KMh9BLv3jo1uXjkQsmP6dZJl21A8k+0nQs8SgwEepqCo2R0F0pmVme46xltN5FCinzKpFhzvc FpHV7lT1qk/K/MzpRaJYeO0dFP4AtW1bf1lb+ViixlnWOf52uC7kM3n+kjS6jDjqMWFCMyQKU 62XFzp8x/0QA377u3Cjd+IbjYiBlOTJFaWX1niiAF9FCkMbijxaZJDKmlUp3AN5q/uoLJJ3ec LLdbw9YPv94rKiyKDcNyEwHd6XO3DeUb7LIhunACzZRNDdq/mXP2PM1Jo3CJI4iCdvp42PvJ/ QTtKfBrgwQRyZnUndnQsJACGgZK1TezDSf6b9MaTOdRjLjEmS6PcK1g5HPr+OAr7TW/ngykmU hw190w8Ac5w2wRfChp459HToE36AdYNaRO4mn+CBXD/Vd8PYUvAC+Z6I8Svc6zEB8BjwlVLCB F2pddlokdHZebiTWHOf6Wv7cPkr00SbTM4GXwc44vlUcObPcysIakpoEnDqUIh9vfMx1tPoBn B02LsdkDE+vtwvMOgzKBlMYvm3iAsCZk6pEuNuHYF4guzV9TAcSblwyGP0us9uchRMrxiYuT+ T0neRESKDVPs+xvT788tIqx8ICRDBBgYVN7H4hQtMe18ZymrSyT4RqIFe89mwyFf9/Yuipy04 sM6V2rTSLVNf9LKpxXXdrkNBZFuFH5tR3i+F8MIaAA4oyKcsb5P2vTLY= Message-ID-Hash: N5MWJV4NPYLHHSXGARXAQQFBKAJQ5C4I X-Message-ID-Hash: N5MWJV4NPYLHHSXGARXAQQFBKAJQ5C4I X-MailFrom: laurent@vivier.eu X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/24/26 16:24, Stefano Brivio wrote: > On Tue, 24 Feb 2026 13:22:27 +0100 > Laurent Vivier wrote: >=20 >> The comment headers for tcp_vu_hdrlen() and udp_vu_hdrlen() described >> the return value as "the size of the header in level 2 frame", but >> these functions also include the virtio net header, which is not part >> of the L2 frame. >> >> Signed-off-by: Laurent Vivier >> --- >> tcp_vu.c | 4 ++-- >> udp_vu.c | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/tcp_vu.c b/tcp_vu.c >> index 94169c21f700..8908d376a7dd 100644 >> --- a/tcp_vu.c >> +++ b/tcp_vu.c >> @@ -40,10 +40,10 @@ static struct vu_virtq_element elem[VIRTQUEUE_MAX_S= IZE]; >> static int head[VIRTQUEUE_MAX_SIZE + 1]; >> =20 >> /** >> - * tcp_vu_hdrlen() - return the size of the header in level 2 frame (T= CP) >> + * tcp_vu_hdrlen() - Return the size of virtio net and L2 headers (TCP= ) >=20 > Thanks, I think that this, plus the line changed below, makes it clear. >=20 > What I still find confusing is: "L2 headers (TCP)". If I see this > together with udp_vu_hdrlen() I understand what you mean, but > otherwise I'd ask myself what TCP has to do with Layer-2... >=20 > I tried rephrasing it a bit, what do you think about: >=20 > * tcp_vu_hdrlen() - Sum size of all headers, from TCP to virtio-net >=20 >> * @v6: Set for IPv6 packet >> * >> - * Return: return the size of the header >> + * Return: total size of virtio net header, Ethernet, IP and TCP heade= rs >=20 > ...and changing this to "virtio-net" (not a very official name but it > seems to be widely used, more than "virtio net"...)? >=20 > If you're fine with it (same for UDP) I would change it and apply. I'm > not exactly proud of this either, so if you or somebody else has better > ideas... I'm fine with it, go ahead... Thanks, Laurent