Re: [PATCH 2/4] treewide: Improve robustness against sockaddrs of unexpected family

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Wed, Apr 16, 2025 at 11:41:31AM +0200, Stefano Brivio wrote:
> On Wed, 16 Apr 2025 19:07:05 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > @@ -239,22 +239,28 @@ static inline void inany_from_af(union inany_addr *aa,
> >  /** inany_from_sockaddr - Extract IPv[46] address and port number from sockaddr
> >   * @aa:		Pointer to store IPv[46] address
> >   * @port:	Pointer to store port number, host order
> > - * @addr:	AF_INET or AF_INET6 socket address
> > + * @addr:	Socket address
> 
> This is actually sa_ now but... can we do something for argument names
> in general, here? What about dst, port, sa, or dst, port, addr?

Sure, done.

> 
> > + *
> > + * Return: 0 on success, -1 on error (bad address family)
> >   */
> > -static inline void inany_from_sockaddr(union inany_addr *aa, in_port_t *port,
> > -				       const union sockaddr_inany *sa)
> > +static inline int inany_from_sockaddr(union inany_addr *aa, in_port_t *port,
> > +				      const void *sa_)
> >  {
> > +	const union sockaddr_inany *sa = (const union sockaddr_inany *)sa_;
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]