From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202504 header.b=a41sDhq7; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 497095A0275 for ; Thu, 17 Apr 2025 03:55:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202504; t=1744854945; bh=UC68WZfr3p6H1q1tmBpPOc3as5XPhA8Ck3fcUQf3rNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a41sDhq7hRpILzA9Grk6bX00uTe7WF09YqSZoNJrJK3vzzCp7yfxjcmG2o3rDLaBz pfGzyZ5iRFUYgTM+wogC8lFaAW12T3/bkewtvHxbzZWxyE429NPRZ21i5QCjEMPXEV VoJw2J2RrHpV6M3eWEZ1K7c5jbOOt1fovHAMGDu9qpJOBhfgEDDtWZEwOZxeP+PJq0 CbKEtvIME/fAjOZecEHxtmMJZpQzukSkYX65iVsc9U25x6eM5C+bXUoupDCX/FoR3n nnNg051S0WzELFfRrHyqombfMH51Qi7b4TD5/D63wVVfb8q9DsacGKGQBuZWso3kJS CHlMuJL2BJHEg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZdLZn67GCz4xRn; Thu, 17 Apr 2025 11:55:45 +1000 (AEST) Date: Thu, 17 Apr 2025 11:14:09 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/4] treewide: Improve robustness against sockaddrs of unexpected family Message-ID: References: <20250416090707.393497-1-david@gibson.dropbear.id.au> <20250416090707.393497-3-david@gibson.dropbear.id.au> <20250416114131.6592c712@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RpK5r9FABlZBlzng" Content-Disposition: inline In-Reply-To: <20250416114131.6592c712@elisabeth> Message-ID-Hash: UFILIVRAQPROHR3D6KDS77W7CP75BIF2 X-Message-ID-Hash: UFILIVRAQPROHR3D6KDS77W7CP75BIF2 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --RpK5r9FABlZBlzng Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 16, 2025 at 11:41:31AM +0200, Stefano Brivio wrote: > On Wed, 16 Apr 2025 19:07:05 +1000 > David Gibson wrote: >=20 > > @@ -239,22 +239,28 @@ static inline void inany_from_af(union inany_addr= *aa, > > /** inany_from_sockaddr - Extract IPv[46] address and port number from= sockaddr > > * @aa: Pointer to store IPv[46] address > > * @port: Pointer to store port number, host order > > - * @addr: AF_INET or AF_INET6 socket address > > + * @addr: Socket address >=20 > This is actually sa_ now but... can we do something for argument names > in general, here? What about dst, port, sa, or dst, port, addr? Sure, done. >=20 > > + * > > + * Return: 0 on success, -1 on error (bad address family) > > */ > > -static inline void inany_from_sockaddr(union inany_addr *aa, in_port_t= *port, > > - const union sockaddr_inany *sa) > > +static inline int inany_from_sockaddr(union inany_addr *aa, in_port_t = *port, > > + const void *sa_) > > { > > + const union sockaddr_inany *sa =3D (const union sockaddr_inany *)sa_; >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --RpK5r9FABlZBlzng Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmgAVckACgkQzQJF27ox 2GfQog//eifYppafY30CfND8hzrYQ+sfGvHqxwc67ojCjixE6TV+6j1G+7wAd9Fs rt3mpf8Vudpo+L+tjWPgL+q87sooVE+0ibrk74eoogx2bykjw0eaxiMwQTPWFRN1 QedWF2vhy0u5TLGrTqpEn+rAoy7D080NlYGHfE4bh9afqJ5GXT8pOnqmyFCfR7CW QGgz14pSZHtC7xyhmOWKDsLZ8nr9O21n//0WgHbHVvuF3zSQ00QzShUlvIXLU8d/ 1D7Zf9DJaNTukfYlmdrCzkUZ654o7iq4pRM+krFadFbBTnvYE5mDaiG6esZGKzZV 8/Lr04S4+D3v1WqN4GxPFfd1bSmmSiyvo5KnoJdMciZb4//xUpJfPI04VThHk2rG 0Nu0Xo2LoFw5qT9oQD7QKVAxFrNyZElBCEuA4uQgCkMHV4T5lbj03457J14nC18p oIDU08KV3klBPYAxK/5wobgaj4CDDHo68m3Bep1v4VDdZHxOu4BRhZ9RXV1F8Iay zFKYWzGxtBOZ/F4yeK3+PJEbWaGWGWB38+qRsKq9hCXDXT3j4cO9i3FQxoTTnLMT ky/a4FehUBt709X3rm0YKyPQKyZpLwUPX26hyPs1n0oLFLLGUuZkcuUIYKAOCnGk ItUPRkVtLn3Q0hMQsRJ4Hxkbu4QnmjTpSlDTOC9C0GKCb01snP4= =iZsI -----END PGP SIGNATURE----- --RpK5r9FABlZBlzng--