From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202504 header.b=bpYel+Ls; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 80E045A026F for ; Fri, 25 Apr 2025 09:46:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202504; t=1745567169; bh=FJ7UvmxIE7WSsdW11Fjk8RxadXB4u7qGcedkvMmHxLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bpYel+LsT4LOm+MF16Vw4g/KjA5yVrUgFqCsQNe3Zdb+W6TPJBJBk+jPZDYnvAaRh G2LRjpTcFhzYQPI+CNkk2ie/bVxFdxrFlmM64/MAr/ny6t2K9t90LZXD+faZYL/n6f tnzaHagd/jV6kakAiIGrTvlW236uccj/6bZcvXE5NcpKpfZ4CdQbnzHhtEN1aDEhGZ pHDQ7HP4SsE7lkYL1/JRYu+RUiORrhQpFnMU5EPQT4byt/+5SKGMQMTqn2TTxYrEUP 9dJu2qqP80PnmNOtKRfyLVGitXlT9G8pQ8y9K3pCMjhP9P1HUEuwSvq3ti8xoUQLdh b6PW8Tk3Ll5PA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ZkPzP2wWDz4x8X; Fri, 25 Apr 2025 17:46:09 +1000 (AEST) Date: Fri, 25 Apr 2025 13:49:26 +0700 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 00/12] Use connect()ed sockets for both sides of UDP flows Message-ID: References: <20250404101542.3729316-1-david@gibson.dropbear.id.au> <20250425082700.0bbbf2a8@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h+bUKcbPyRJD2DlH" Content-Disposition: inline In-Reply-To: <20250425082700.0bbbf2a8@elisabeth> Message-ID-Hash: 4OR7ASYK5J3O6KIP6GD3PF36ACNU5BKU X-Message-ID-Hash: 4OR7ASYK5J3O6KIP6GD3PF36ACNU5BKU X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --h+bUKcbPyRJD2DlH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 25, 2025 at 08:27:00AM +0200, Stefano Brivio wrote: > On Fri, 4 Apr 2025 21:15:30 +1100 > David Gibson wrote: >=20 > > As discussed, I've been working on using connect()ed sockets, rather > > than dups of the listening sockets for handling traffic on the > > initiating side of UDP flows. This improves consistency, avoids some > > problems (bug 103) and will allow for some useful future improvements. > >=20 > > It has the nice side effect of allowing some more code to be shared > > between various paths, resulting in a pretty nice negative diffstat. > >=20 > > David Gibson (12): > > udp: Use connect()ed sockets for initiating side > > udp: Make udp_sock_recv() take max number of frames as a parameter > > udp: Polish udp_vu_sock_info() and remove from vu specific code > > udp: Don't bother to batch datagrams from "listening" socket > > udp: Parameterize number of datagrams handled by > > udp_*_reply_sock_data() > > udp: Split spliced forwarding path from udp_buf_reply_sock_data() > > udp: Merge vhost-user and "buf" listening socket paths > > udp: Move UDP_MAX_FRAMES to udp.c > > udp_flow: Take pif and port as explicit parameters to > > udp_flow_from_sock() > > udp: Rework udp_listen_sock_data() into udp_sock_fwd() > > udp: Fold udp_splice_prepare and udp_splice_send into udp_sock_to_sock > > udp_flow: Don't discard packets that arrive between bind() and > > connect() >=20 > Just for the record: it's likely that something here made > https://github.com/containers/podman/issues/25959 more visible (or > directly caused it). I couldn't rule out recent ICMP changes yet, > but I'm fairly sure it's not those. Drat. I concur this series is the likely culprit. First place to check would be the error paths for a flow initiated from the host side (there are new ones because this now involves opening a new socket). Maybe we didn't clean something up in one of those cases leaving a bomb for a future allocation. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --h+bUKcbPyRJD2DlH Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmgLMGcACgkQzQJF27ox 2Gfn3g//QjHqwsw1SXLhQH6BFhitBAtySr5wuyvwPcBKybc+NzlNJRC5ZqT9fRBX oS4j82WObPMjPx9DqMmeayv3rOASIO5VFd8H00e5z2BveazqBMPmKzLoY/Aqwu/3 fUoGZAzNRB9Xdk7ePLrD/w6rMirt9e4Zb4d6RDakXqPtK6P9LBWqbO3IKW0rwtf8 sNesP4GFSYNOmaDh9iqd0l3JNfot9954TLVPPOLCNwvNLCmCN/kvg2PMMhI3Np+d kKyHn/puEB5C+pM/cdKllacjoGuyS7HIL6HOmmVqgFn85p2QsVg2vXexPjf/gyoe kLbJTC0o1tkL0Ru4vOmKD2cl47mpP8csznf/PecUUdrv+TabCjbUgXRUNoxEqF36 5MkjVC8wor2eUM9Vx79z075moiA+rpU4IUva5/mL0Er3xz+K0mxHec/sl+cPvPJh P+6iGWKguF5uoW0mb7FefCEgFkcAM1mm218hvD96v2n2RNIlzu+qpScqsFj/lqi5 LjXWWvJZQHFBVNMOaKyz3rUrXkB4r0BGx4ZIGfqkg66Et+KwXBTAUOMBlHQq9s+f wMpPjSFAsupeL0Ln3Hkx82ldAbyLxgQZSYfNvxZ1POW4fiC36WpHmgox3Ky0cwhc Pm3MlnYnKeYUp0Afm9eBYKZt8lUKapGx/RgRqK5TFFmUv9A0k80= =JioU -----END PGP SIGNATURE----- --h+bUKcbPyRJD2DlH--