From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] util: Fix typo, ASSSERTION -> ASSERTION
Date: Wed, 30 Apr 2025 22:18:30 +0700 [thread overview]
Message-ID: <aBI_RmETDlpddXFI@zatzit> (raw)
In-Reply-To: <20250430150137.571600-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]
On Wed, Apr 30, 2025 at 05:01:37PM +0200, Stefano Brivio wrote:
> Fixes: 9153aca15bc1 ("util: Add abort_with_msg() and ASSERT_WITH_MSG() helpers")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Oops, that's embarrassing. Or possible embarrasssing.
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> util.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util.h b/util.h
> index cc7d084..5947337 100644
> --- a/util.h
> +++ b/util.h
> @@ -75,7 +75,7 @@ void abort_with_msg(const char *fmt, ...)
> #define ASSERT_WITH_MSG(expr, ...) \
> ((expr) ? (void)0 : abort_with_msg(__VA_ARGS__))
> #define ASSERT(expr) \
> - ASSERT_WITH_MSG((expr), "ASSSERTION FAILED in %s (%s:%d): %s", \
> + ASSERT_WITH_MSG((expr), "ASSERTION FAILED in %s (%s:%d): %s", \
> __func__, __FILE__, __LINE__, STRINGIFY(expr))
>
> #ifdef P_tmpdir
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-04-30 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 15:01 [PATCH] util: Fix typo, ASSSERTION -> ASSERTION Stefano Brivio
2025-04-30 15:18 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBI_RmETDlpddXFI@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).