From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] passt-repair: Fix missing newlines in error messages
Date: Wed, 4 Jun 2025 21:01:22 +1000 [thread overview]
Message-ID: <aEAngiTey4IyXFI0@zatzit> (raw)
In-Reply-To: <20250604103250.4190812-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]
On Wed, Jun 04, 2025 at 12:32:50PM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> passt-repair.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/passt-repair.c b/passt-repair.c
> index ff1c44f..8c59d7e 100644
> --- a/passt-repair.c
> +++ b/passt-repair.c
> @@ -83,7 +83,7 @@ int main(int argc, char **argv)
> prog.filter = filter_repair;
> if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) ||
> prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog)) {
> - fprintf(stderr, "Failed to apply seccomp filter");
> + fprintf(stderr, "Failed to apply seccomp filter\n");
> _exit(1);
> }
>
> @@ -134,13 +134,13 @@ int main(int argc, char **argv)
>
> n = read(fd, buf, sizeof(buf));
> if (n < 0) {
> - fprintf(stderr, "inotify read: %i", errno);
> + fprintf(stderr, "inotify read: %i\n", errno);
> _exit(1);
> }
> buf[n - 1] = '\0';
>
> if (n < (ssize_t)sizeof(*ev)) {
> - fprintf(stderr, "Short inotify read: %zi", n);
> + fprintf(stderr, "Short inotify read: %zi\n", n);
> continue;
> }
>
> @@ -176,7 +176,7 @@ int main(int argc, char **argv)
> }
>
> if (ret <= 0 || ret >= (int)sizeof(a.sun_path)) {
> - fprintf(stderr, "Invalid socket path");
> + fprintf(stderr, "Invalid socket path\n");
> _exit(2);
> }
>
> @@ -245,8 +245,8 @@ loop:
> for (i = 0; i < n; i++) {
> if (setsockopt(fds[i], SOL_TCP, TCP_REPAIR, &op, sizeof(op))) {
> fprintf(stderr,
> - "Setting TCP_REPAIR to %i on socket %i: %s", op,
> - fds[i], strerror(errno));
> + "Setting TCP_REPAIR to %i on socket %i: %s\n",
> + op, fds[i], strerror(errno));
> _exit(1);
> }
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-06-04 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 10:32 [PATCH] passt-repair: Fix missing newlines in error messages Stefano Brivio
2025-06-04 11:01 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEAngiTey4IyXFI0@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).