Re: [PATCH] passt-repair: Fix missing newlines in error messages

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

On Wed, Jun 04, 2025 at 12:32:50PM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  passt-repair.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/passt-repair.c b/passt-repair.c
> index ff1c44f..8c59d7e 100644
> --- a/passt-repair.c
> +++ b/passt-repair.c
> @@ -83,7 +83,7 @@ int main(int argc, char **argv)
>  	prog.filter = filter_repair;
>  	if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) ||
>  	    prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog)) {
> -		fprintf(stderr, "Failed to apply seccomp filter");
> +		fprintf(stderr, "Failed to apply seccomp filter\n");
>  		_exit(1);
>  	}
>  
> @@ -134,13 +134,13 @@ int main(int argc, char **argv)
>  
>  			n = read(fd, buf, sizeof(buf));
>  			if (n < 0) {
> -				fprintf(stderr, "inotify read: %i", errno);
> +				fprintf(stderr, "inotify read: %i\n", errno);
>  				_exit(1);
>  			}
>  			buf[n - 1] = '\0';
>  
>  			if (n < (ssize_t)sizeof(*ev)) {
> -				fprintf(stderr, "Short inotify read: %zi", n);
> +				fprintf(stderr, "Short inotify read: %zi\n", n);
>  				continue;
>  			}
>  
> @@ -176,7 +176,7 @@ int main(int argc, char **argv)
>  	}
>  
>  	if (ret <= 0 || ret >= (int)sizeof(a.sun_path)) {
> -		fprintf(stderr, "Invalid socket path");
> +		fprintf(stderr, "Invalid socket path\n");
>  		_exit(2);
>  	}
>  
> @@ -245,8 +245,8 @@ loop:
>  	for (i = 0; i < n; i++) {
>  		if (setsockopt(fds[i], SOL_TCP, TCP_REPAIR, &op, sizeof(op))) {
>  			fprintf(stderr,
> -				"Setting TCP_REPAIR to %i on socket %i: %s", op,
> -				fds[i], strerror(errno));
> +				"Setting TCP_REPAIR to %i on socket %i: %s\n",
> +				op, fds[i], strerror(errno));
>  			_exit(1);
>  		}
>  

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]