From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202504 header.b=kQ+5wC4k; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id B081C5A0282 for ; Wed, 04 Jun 2025 13:42:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202504; t=1749037341; bh=oBxis0z/DLrFmTXSSBfXToEKUIMiRW7yTdxHDUluj0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kQ+5wC4k/vLUfjZKfM+zsXsASbl1NsqWIc8xyDkzkBEwmruWnvyRHgnFcZA0Nf0Zx aziW7jpUp8PMSRw+6CjxXMYHV2AXAGqdSuap5KU3135LzRd160sVzOZJhL8ZKkSLTJ KftbdihMAuPN0V+sa3mQdHUkB0OA8vcymOfZkbWXL0QWnMvNUg1mvsy6OoxDcy08bm Z4mM/kBCrSpcELZGaxEgkzdrXfCESe4tfY0uXGl36Y3of/HoTHD/c4CY4WApQuPb/H VAurSbjb7FOzJ8LaXXye2a4JI7Qsb1I0K+09S0aW+gaL71NH7aY6+4/7XZwSpQtvT0 SXy8EitN/GcAw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4bC5KT2pdNz4x9D; Wed, 4 Jun 2025 21:42:21 +1000 (AEST) Date: Wed, 4 Jun 2025 21:01:22 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] passt-repair: Fix missing newlines in error messages Message-ID: References: <20250604103250.4190812-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NvrB3I6FcPA6b6Mr" Content-Disposition: inline In-Reply-To: <20250604103250.4190812-1-sbrivio@redhat.com> Message-ID-Hash: QHTUWUIP3GIUPYTIAT6TUJ44E3ITFRD5 X-Message-ID-Hash: QHTUWUIP3GIUPYTIAT6TUJ44E3ITFRD5 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --NvrB3I6FcPA6b6Mr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 04, 2025 at 12:32:50PM +0200, Stefano Brivio wrote: > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > passt-repair.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/passt-repair.c b/passt-repair.c > index ff1c44f..8c59d7e 100644 > --- a/passt-repair.c > +++ b/passt-repair.c > @@ -83,7 +83,7 @@ int main(int argc, char **argv) > prog.filter =3D filter_repair; > if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) || > prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog)) { > - fprintf(stderr, "Failed to apply seccomp filter"); > + fprintf(stderr, "Failed to apply seccomp filter\n"); > _exit(1); > } > =20 > @@ -134,13 +134,13 @@ int main(int argc, char **argv) > =20 > n =3D read(fd, buf, sizeof(buf)); > if (n < 0) { > - fprintf(stderr, "inotify read: %i", errno); > + fprintf(stderr, "inotify read: %i\n", errno); > _exit(1); > } > buf[n - 1] =3D '\0'; > =20 > if (n < (ssize_t)sizeof(*ev)) { > - fprintf(stderr, "Short inotify read: %zi", n); > + fprintf(stderr, "Short inotify read: %zi\n", n); > continue; > } > =20 > @@ -176,7 +176,7 @@ int main(int argc, char **argv) > } > =20 > if (ret <=3D 0 || ret >=3D (int)sizeof(a.sun_path)) { > - fprintf(stderr, "Invalid socket path"); > + fprintf(stderr, "Invalid socket path\n"); > _exit(2); > } > =20 > @@ -245,8 +245,8 @@ loop: > for (i =3D 0; i < n; i++) { > if (setsockopt(fds[i], SOL_TCP, TCP_REPAIR, &op, sizeof(op))) { > fprintf(stderr, > - "Setting TCP_REPAIR to %i on socket %i: %s", op, > - fds[i], strerror(errno)); > + "Setting TCP_REPAIR to %i on socket %i: %s\n", > + op, fds[i], strerror(errno)); > _exit(1); > } > =20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --NvrB3I6FcPA6b6Mr Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmhAJ28ACgkQzQJF27ox 2Gcetg//W/fUrZIRZOAhBb8XdVJzTCoqyxZs6g/h35Kjm+/qCFwAiyEtoq+gDAY+ jecWwVsZs0/h/1ilAj7oiL47SLesOWJOeY37Dgke2TA1ALyjCoRmZFY/fZuKb3US b+e7M7jUQK+33cGTIw1kEwSrPPbhcfPv9PHjVu8kRcdKen+x/uS2cpbtHUTCNXp0 3f0JUxQ7Bffsn6wmTVews/rW5OoR1xv1vl0PF1ptcXC9dRJU62wIbKc3uzcjUx3X hUxX8P4ZFxhFaJppiitBVBU0r3CxVI4As/tU+8+K9huXfQtk4ESDWruVpY/IGZuP G0vJWT2XNzDS/pqFNApJumFvq2OtuPhiLttl4e6ZQsHjzhEwi8X9tkmnJdOwIYFK 4rOq45iV9EmikrhIeZUaIQ4biyTHFRyJL+2+xP5ES4o8sxolHR8vow+QPNLsY1Ff +/c/jOh+Tt816njH4dau77L22EwtNYz6dtJCKWnr1G+tQcSL8N2pAh5pMz0IuUB5 mDUqW7T2oxSEXvex6rGekfucI3QaIbVa+mxkRZjr+Un77r7KZWVKSaiPvNS/AVqm mO49AGiYcIIimSL1L+k7iJ4EU959JyWEwGd7x3tDe5RXhkdmbcTtLLhAABkDqoU7 9gWR7Y7dpbCoHbY4e5LF70eRXKNawmuraTaapi82eIow+xekSeY= =SeX3 -----END PGP SIGNATURE----- --NvrB3I6FcPA6b6Mr--