Re: [RFC v2 05/11] virtio: Fill .next in tx queue

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

On Wed, Jul 09, 2025 at 07:47:42PM +0200, Eugenio Pérez wrote:
> This way we can send one frame splitted in many buffers. TCP stack

English usage node: s/splitted/split/.

> already works this way in pasta.
> 
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
>  tap.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tap.c b/tap.c
> index 8b3ec45..5667fbe 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -1727,6 +1727,9 @@ static int tap_ns_tun(void *arg)
>  		vring_desc[0][i].len = PKT_BUF_BYTES/VHOST_NDESCS;
>  		vring_desc[0][i].flags = VRING_DESC_F_WRITE;
>  	}
> +	for (i = 0; i < (VHOST_NDESCS - 1); ++i) {
> +		vring_desc[1][i].next = i+1;
> +	}

passt style omits { }  here.

>  	for (i = 0; i < VHOST_NDESCS; ++i) {
>  		vring_avail_0.avail.ring[i] = i;
>  	}

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]