From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202506 header.b=S2EV7uqW; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 588F25A0283 for ; Wed, 23 Jul 2025 09:21:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202506; t=1753255150; bh=lZ8ynKIXMv72DkryPcPbBTb4/4D5PiXqdby3Re2O15Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S2EV7uqWNV7q55ub/hkuK+SCeMhpX2Mz/Ijs37eP/XM74GdH19c0qXsGKXO7UqZwy WIVBa7yag/MfxRle7ln9KkvF2kNIqDvXYk5h1unGZRjhbuukap5gxLoY6KzlZYI7rT e59vdLr5drU6m+XN6BLkrI2+Flwa27+CMJycpVBQzSECFR+ssE0iCk5KC+OQ/Y1z6H BBaJYCQYjPcqaDxJKVdRWB/5aOQkfqIu7SI+kkh57v24VNOBACHmW44xjFzAN0vmX9 Q0Ap/Q9/Q+s3xkPcZEHVnywAS52VT3DI/JhsyUfi4yZS3PUpiUMz/hng9DsWn7AiYJ uicwyXYg8QS6g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4bn59B07h1z4xDQ; Wed, 23 Jul 2025 17:19:10 +1000 (AEST) Date: Wed, 23 Jul 2025 17:07:54 +1000 From: David Gibson To: Eugenio =?iso-8859-1?Q?P=E9rez?= Subject: Re: [RFC v2 05/11] virtio: Fill .next in tx queue Message-ID: References: <20250709174748.3514693-1-eperezma@redhat.com> <20250709174748.3514693-6-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AxJ4145TCQee186V" Content-Disposition: inline In-Reply-To: <20250709174748.3514693-6-eperezma@redhat.com> Message-ID-Hash: QI6PP5GL2PNZGWAHGA227RGS7W24DGDH X-Message-ID-Hash: QI6PP5GL2PNZGWAHGA227RGS7W24DGDH X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jasowang@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --AxJ4145TCQee186V Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 09, 2025 at 07:47:42PM +0200, Eugenio P=E9rez wrote: > This way we can send one frame splitted in many buffers. TCP stack English usage node: s/splitted/split/. > already works this way in pasta. >=20 > Signed-off-by: Eugenio P=E9rez > --- > tap.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/tap.c b/tap.c > index 8b3ec45..5667fbe 100644 > --- a/tap.c > +++ b/tap.c > @@ -1727,6 +1727,9 @@ static int tap_ns_tun(void *arg) > vring_desc[0][i].len =3D PKT_BUF_BYTES/VHOST_NDESCS; > vring_desc[0][i].flags =3D VRING_DESC_F_WRITE; > } > + for (i =3D 0; i < (VHOST_NDESCS - 1); ++i) { > + vring_desc[1][i].next =3D i+1; > + } passt style omits { } here. > for (i =3D 0; i < VHOST_NDESCS; ++i) { > vring_avail_0.avail.ring[i] =3D i; > } --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --AxJ4145TCQee186V Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmiAikkACgkQzQJF27ox 2GdcnQ/7BlzpabgigD8wCvDnqRVALd9/rOizv3ihKT6aXD4Quu0I5tFdkDcSbi8B oPWVOAaLpOICo3kwBG0hnhBrqujBC9vPsXTZBw56gmKNnIaIvkjV7UH9aOgHm2dW UjvR9lqGzFLfgChqzSLPbeLBIUflkmXnCnY53VkG3Bhe4ssp6IezHWsZkylUqwxh rtFPvhQ80kPwwSm4oz4JroHtYDAB3fl+qtPgijO+k+us9UxJqQECd0cpXqFBYY8f as/tzsrociEjk/z2dV07sioQdq10fU/A2c66uB7OaajwaULtMmpfQdAjEeB13/LJ pLvBps7YYTUIXBypzzIBIdYlHzPTEoKuDVh6kQzNYe4kHNFELL3udi9oTxHnaS8O OO6xaoq27SOy5m8BXIt2m1JnsMQNo2rpPvf7vltWb070BBDAmXBKazqsA9CF6Ip/ d4N/hk7QuOQKv14gqZGVmRVf5c51B2tM9nTn4S5mnYMGsdYsCdj1LOKfJTRQzGb/ mbRBFXV214HBN15+8q+gxZYrC1flYWOb8YODdW/Chq6b8ddksBzAnRUtKT9XjRF7 8ajw1vhRYN4AcXpwSOTq0sVaUb6LudIIQrCOHwFZC6WUIA7pBhReYKyRa+kt5/HU U1km/GApcj41njYuIWc/AatXFMypwLB8/ueARb2HGCMwcQiQi5M= =WdtF -----END PGP SIGNATURE----- --AxJ4145TCQee186V--