From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202506 header.b=VcIZMByE; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id F34F05A027A for ; Tue, 29 Jul 2025 02:32:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202506; t=1753748965; bh=hWowRr3wlrvMmxLzrpOJzcto/sKKCivIZ7RVDWTVHQI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VcIZMByEPKDmd+bJM3ZsHKheYFnmwjE/xWT155A/4XbEwLftkiuQZ1LQAkf2mwMRt +uL2hqujx5jtUvD6cQcjzKF0aXzOwCmfkssagXXM1BcizVm+iy1WWpcO5OQUShLvV0 oJacjrOYuS3J7GvJdjQrBzYQviFBN+ogD7AVLJADPFOPWrvT2J5YPpabNDsEcU3xVn gt20MIbPUnT7N/gOVtKPFZ9pAE6so1VNjqO5K7u+1jvWeYUvtH33Pi2NOQ9X0d27Ih wvrIOd+3l3MA8OfQynelxbbWkE2gVh3jSidp/DakUfe75UzPoYp6hX7yTZUD26ymPE cVIr+NLt+8SJQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4brbnd2typz4wbd; Tue, 29 Jul 2025 10:29:25 +1000 (AEST) Date: Tue, 29 Jul 2025 10:25:01 +1000 From: David Gibson To: Eugenio Perez Martin Subject: Re: [RFC v2 04/11] tcp: export memory regions to vhost Message-ID: References: <20250709174748.3514693-1-eperezma@redhat.com> <20250709174748.3514693-5-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+sFouGZYvLqYAoS2" Content-Disposition: inline In-Reply-To: Message-ID-Hash: 7U5OR3P7N2LVVPIJ2D5YS3N4OZULWXE4 X-Message-ID-Hash: 7U5OR3P7N2LVVPIJ2D5YS3N4OZULWXE4 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jasowang@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --+sFouGZYvLqYAoS2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 28, 2025 at 06:41:20PM +0200, Eugenio Perez Martin wrote: > On Wed, Jul 23, 2025 at 9:06=E2=80=AFAM David Gibson > wrote: > > > > On Wed, Jul 09, 2025 at 07:47:41PM +0200, Eugenio P=C3=A9rez wrote: > > > So vhost kernel is able to access the TCP buffers. > > > > > > Signed-off-by: Eugenio P=C3=A9rez > > > --- > > > tap.c | 14 +++++++++++--- > > > tcp_buf.c | 14 ++++---------- > > > tcp_buf.h | 19 +++++++++++++++++++ > > > 3 files changed, 34 insertions(+), 13 deletions(-) > > > > > > diff --git a/tap.c b/tap.c > > > index 0656294..8b3ec45 100644 > > > --- a/tap.c > > > +++ b/tap.c > > > @@ -63,6 +63,8 @@ > > > #include "vhost_user.h" > > > #include "vu_common.h" > > > > > > +#include "tcp_buf.h" > > > + > > > > I don't love including the pretty specific content of tcp_buf.h into > > the mostly protocol unaware tap.c. Though I do realise that avoiding > > it will probably have other tradeoffs. >=20 > I was more focused on testing the performance of the solution than > making it pretty, but I'm a big fan of hiding the buffers somehow :). > I just didn't explore the options. Ok, that's fine for now then. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --+sFouGZYvLqYAoS2 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmiIFNwACgkQzQJF27ox 2GfCIBAAgGHt7ilmES5DBPgM0AhahAlCWcP7G62RJ2fYXrzLO3lTmlG5nfFNgyt8 iXOX6OWuWC0afP2RAXjJqbhdIAHJhg1X+Ao8LiEOR9rrzwPsj7SVfAqHFICOUaxy dB8XIQC8kd3VEvWQH4rAjgQuMwdBXltgf9z329rpSJ4oQ1TCM0dRaG2wH2TXTx2S Lbwnd1Zem0Ja2JT0xoAkVcfEml8KwVQVeIPkbgti+7mBtxjTOxGKNyQlxY+Hfrij O/l7iPzR7SSA9KjB0KqnM8Y7P1qTit8G9nZIDy1T4C0NTe33WXzRJC/gFWP5Azov pMKL4jnCTncAdf/THXBm8OLfaIaWlPiQU6W9SQ9kkDLApH8ybp7XZBnkg5CdWDgN nYiQJyZ6NA4rTrMdw9kdDk98SN1twUnx3CFJzZ+rQHJ7qeOpgj2JQ01xAP+yR9cn uNA/8/A9FKQlwMaS2Q6DECdB3Lb03wWmi14T7HosMJdLhR0CnsJMJ6HzZ9dJ1yHS JBB2krguw3aCFJJS/z+DrGP3tm5qd5PLT0JfvRxgJxNWWPUjcrKVYiBWxbCeBOqD 6oWVReDVBXW+W6RUWUHl7DjcQc9GrJ3QGVFPT1c0X9knw+BuBlyyVU/UwwqMJrNw j/9wF4wzh28w/mLTVEb1K3//wXIctlwRKUJUlXL5FNTCEU0n7w0= =Fe+n -----END PGP SIGNATURE----- --+sFouGZYvLqYAoS2--