From: David Gibson <david@gibson.dropbear.id.au>
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: passt-dev@passt.top, jasowang@redhat.com
Subject: Re: [RFC v2 06/11] tap: move static iov_sock to tcp_buf_data_from_sock
Date: Tue, 29 Jul 2025 10:28:25 +1000 [thread overview]
Message-ID: <aIgVqbOD5W1SPdWa@zatzit> (raw)
In-Reply-To: <CAJaqyWeMD-tS8zbtTCYfOhA852PoiWay9XTnD0DW90st+UqyEQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
On Mon, Jul 28, 2025 at 06:43:50PM +0200, Eugenio Perez Martin wrote:
> On Wed, Jul 23, 2025 at 9:22 AM David Gibson
> <david@gibson.dropbear.id.au> wrote:
> >
> > On Wed, Jul 09, 2025 at 07:47:43PM +0200, Eugenio Pérez wrote:
> > > As it is the only function using it. I'm always confusing it with
> > > tcp_l2_iov, moving it here avoids it.
> > >
> > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> >
> > I like making it local, I'd question whether it even needs to remain 'static'.
> >
>
> Probably not, I was just worried about a stack overflow. But I didn't
> measure its size to be honest.
I think we have comparable sized things on the stack already, such as
mmsghdr[UIO_MAXIOV] in udp_tap_handler.
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-07-29 0:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 17:47 [RFC v2 00/11] Add vhost-net kernel support Eugenio Pérez
2025-07-09 17:47 ` [RFC v2 01/11] tap: implement vhost_call_cb Eugenio Pérez
2025-07-23 6:56 ` David Gibson
2025-07-28 16:33 ` Eugenio Perez Martin
2025-07-29 0:11 ` David Gibson
2025-07-09 17:47 ` [RFC v2 02/11] tap: add die() on vhost error Eugenio Pérez
2025-07-23 6:58 ` David Gibson
2025-07-09 17:47 ` [RFC v2 03/11] tap: replace tx tap hdr with virtio_nethdr_mrg_rxbuf Eugenio Pérez
2025-07-24 0:17 ` David Gibson
2025-07-28 16:37 ` Eugenio Perez Martin
2025-07-09 17:47 ` [RFC v2 04/11] tcp: export memory regions to vhost Eugenio Pérez
2025-07-23 7:06 ` David Gibson
2025-07-28 16:41 ` Eugenio Perez Martin
2025-07-29 0:25 ` David Gibson
2025-07-09 17:47 ` [RFC v2 05/11] virtio: Fill .next in tx queue Eugenio Pérez
2025-07-23 7:07 ` David Gibson
2025-07-28 16:44 ` Eugenio Perez Martin
2025-07-09 17:47 ` [RFC v2 06/11] tap: move static iov_sock to tcp_buf_data_from_sock Eugenio Pérez
2025-07-23 7:09 ` David Gibson
2025-07-28 16:43 ` Eugenio Perez Martin
2025-07-29 0:28 ` David Gibson [this message]
2025-07-09 17:47 ` [RFC v2 07/11] tap: support tx through vhost Eugenio Pérez
2025-07-24 0:24 ` David Gibson
2025-07-24 14:30 ` Stefano Brivio
2025-07-25 0:23 ` David Gibson
2025-07-09 17:47 ` [RFC v2 08/11] tap: add tap_free_old_xmit Eugenio Pérez
2025-07-24 0:32 ` David Gibson
2025-07-28 16:45 ` Eugenio Perez Martin
2025-07-09 17:47 ` [RFC v2 09/11] tcp: start conversion to circular buffer Eugenio Pérez
2025-07-24 1:03 ` David Gibson
2025-07-28 16:55 ` Eugenio Perez Martin
2025-07-29 0:30 ` David Gibson
2025-07-09 17:47 ` [RFC v2 10/11] tap: add poll(2) to used_idx Eugenio Pérez
2025-07-24 1:20 ` David Gibson
2025-07-28 17:03 ` Eugenio Perez Martin
2025-07-29 0:32 ` David Gibson
2025-07-29 7:04 ` Eugenio Perez Martin
2025-07-30 0:32 ` David Gibson
2025-07-09 17:47 ` [RFC v2 11/11] tcp_buf: adding TCP tx circular buffer Eugenio Pérez
2025-07-24 1:33 ` David Gibson
2025-07-28 17:04 ` Eugenio Perez Martin
2025-07-10 9:46 ` [RFC v2 00/11] Add vhost-net kernel support Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIgVqbOD5W1SPdWa@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).