From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202506 header.b=VS9EsRN2; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 64F585A027C for ; Tue, 29 Jul 2025 02:32:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202506; t=1753748965; bh=mhUuyEJmsB+KjtLOpYulQtGtDWpXJ5gUbM0RxhzXR2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VS9EsRN2QYI2NXcUTPIukdxVTkR1Q4mvSnFtK1N/Pa0xjJO0Uxvs81BB+IVKkjz7e QWErMphyXkKymA7i109aNBh3Re8CRJ1Br0zTAD3wQoOKuZ3BdECjORWvx6hT0ywDdk xdO0I3Zsh9lJkfdE8teq3QiZ7fS1sm/HlNyarmkOQzsrSOKRgJs41vbNZ4mj65s/go WZ2lQsM5TkA1LpVLT3gEnwgrNCl5YDb3xXEJ4Scl6ucC+78sJgqUaC4/Yr1EBi+GsY 13UbHFiqNf1CjXliW78Que8Ls/xSeACb5+ITBnYZ6SBuvyliqjDfY58GOvXMHkovUf 0+ERRFv6+1ktw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4brbnd371Tz4x21; Tue, 29 Jul 2025 10:29:25 +1000 (AEST) Date: Tue, 29 Jul 2025 10:28:25 +1000 From: David Gibson To: Eugenio Perez Martin Subject: Re: [RFC v2 06/11] tap: move static iov_sock to tcp_buf_data_from_sock Message-ID: References: <20250709174748.3514693-1-eperezma@redhat.com> <20250709174748.3514693-7-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hzw4GbXMbm3xMRTp" Content-Disposition: inline In-Reply-To: Message-ID-Hash: OGRY6HQXEIIAT5FYWE4KLYFBTEOQKOIE X-Message-ID-Hash: OGRY6HQXEIIAT5FYWE4KLYFBTEOQKOIE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, jasowang@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --hzw4GbXMbm3xMRTp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 28, 2025 at 06:43:50PM +0200, Eugenio Perez Martin wrote: > On Wed, Jul 23, 2025 at 9:22=E2=80=AFAM David Gibson > wrote: > > > > On Wed, Jul 09, 2025 at 07:47:43PM +0200, Eugenio P=C3=A9rez wrote: > > > As it is the only function using it. I'm always confusing it with > > > tcp_l2_iov, moving it here avoids it. > > > > > > Signed-off-by: Eugenio P=C3=A9rez > > > > I like making it local, I'd question whether it even needs to remain 's= tatic'. > > >=20 > Probably not, I was just worried about a stack overflow. But I didn't > measure its size to be honest. I think we have comparable sized things on the stack already, such as mmsghdr[UIO_MAXIOV] in udp_tap_handler. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --hzw4GbXMbm3xMRTp Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmiIFagACgkQzQJF27ox 2GdwXA/+NVw+iSgUwK2v7mlgMxc3NxyHxls5O5O24Kg/QFEspzmPQ52klgGDnWPW iz7pXv6Qzsz3/bU/QiGRbNvKR3WaWf99l5aCDREPB/0Hf1jaBRppHG03Bw0UlpvI 7ti30a9FKnBzElaw4ISZVWAPIXPfh95fS3mYxZYiKLnHyrDBNZeb7ZaiHXC7pBXX cHiajR0ra0G0QHAXR4S8d6V0Fwyir2Q6efI43F/voBmfBC0YcSIzUAVgvdcsr8Mw xlPlLgD+emGnv/JAGVFJ2Bo0R182SrC7mQa1drPZB+5S1yHhpLfR9Hk3dsJNGFr7 a6SIL+uy14pzamr+djQpQvLNoWxNgZYCF1mtwz+1oXGmFhLnTqDc92UV/ThhVoUH TeZlJs7aKgM4v8jvAarOTTwbZIlHa16bqQXVsL31LXFujKr+s42n15RD6FzPhCRB OzZhQaT+uOYeIa+3tmkDwpNvFajz8xSN1sqGtARQo5ibRGKIT7xKfhwty5ruaJ7x +Y1bkbomXmQFFlMvvo5MxBq3b/k/I/wEZB3mnrANvRXgbuq7ARdtGy9GqCELa4FG rYB5IZlZYL6n62/iQ87u+UFh3iJqv1WQphF7CZVppM/e2ZVJWLLHn8gsdEJLzk+D 93pE4eMQKUYTeerTRCvE8lJglRwFlyEZqn8d4wBZFP16CZ1LJdI= =ETeL -----END PGP SIGNATURE----- --hzw4GbXMbm3xMRTp--