From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=vC8xRVvw; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 39E8E5A0271 for ; Fri, 15 Aug 2025 07:50:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1755237039; bh=Y4w3OjJU7jBUIhNesbgmwt6htmPD9vtgfsH/Us5e2ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vC8xRVvwhB71799HspbZzdr9wEB24KgChMmiUs2SLjTrncbB/IBe/5GABMfgsDUIk 62lqwUUP2R3wd5hK/+bP1UTx5HtTNEj++t4vYy6nVdB+nHBqT0gbclNyzThSlHhitb Xm9GedfRbZ9w7kuViy6vUgG1PPTOSgQHj8rlCCrqDkbwKncarfvVThVtoCrdDmWRso yoI3YXo1avzUwcXU8kLzzQFLP0ih2wVasheJd4bl8MUGVqckzKy/DaDcIapNLyY5LU zOCngeM9ZFf79Ss093zlnDafnUuWoTW2/mZqBwGq3Q+h+3JjYAseBG5T9f1CAzQ5kP 5AlwUAmegIqGw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4c3B6R1zf8z4xfC; Fri, 15 Aug 2025 15:50:39 +1000 (AEST) Date: Fri, 15 Aug 2025 15:50:35 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] treewide: Flush pcap and log files, if used, before exiting Message-ID: References: <20250813164510.3382756-1-sbrivio@redhat.com> <20250814071255.3dfbd733@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="beRCE4wAQu1NyZ2N" Content-Disposition: inline In-Reply-To: <20250814071255.3dfbd733@elisabeth> Message-ID-Hash: 4JGQRFSZYXGBCGUBFS4KR5U2FIHALV6L X-Message-ID-Hash: 4JGQRFSZYXGBCGUBFS4KR5U2FIHALV6L X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --beRCE4wAQu1NyZ2N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 14, 2025 at 07:12:55AM +0200, Stefano Brivio wrote: > On Thu, 14 Aug 2025 14:10:20 +1000 > David Gibson wrote: [snip] > > Here we're adding a new syscall to work around the problems with > > _exit(). In which case, why don't we add futex() to the syscall list > > and go back to exit(3). >=20 > Because futex() just came up unexpectedly and Paul and myself had to > spend hours figuring that out, and there are good chances we'll get > something else like that from glibc in the future. Yes, but that could happen with literally any libc function, I'm not convinced that exit() is a target that deserves special attention. > On top of that, see CVE-2014-3153 and CVE-2020-14381 about futex(). > >From a quick glance (and intuitively) fsync() is much simpler than that. Eh. Still not really convinced this isn't more trouble than it's worth, but as you wish. > > With Laurent working on multi-threading we might well want futexes > > anyhow. >=20 > True, but then I'd still prefer to allow futex() explicitly, rather > than re-enabling exit handlers, because that's more predictable. >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --beRCE4wAQu1NyZ2N Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmieyqsACgkQzQJF27ox 2Ge21A/7Bs4XFobe65i9aMa0OcIrZdJUbbJXHGCmu5DQmsuHS1bhU9MXvPonZRmO trEKStJQUXwi/+Ex/FG6U7vGJAsSOcQl1TkSmj8ETdG1Zq+W6yixwhhWmTwir1zc bAA3sfDrh7kXgdYPaFcuhMG8XRkCqAOvXAnaG9BLmTa6TDqs8iR4ExvTpUhw36Za GXSqCudvDELoCoEqYeX5MhO8pKDItgNNna0zdN9RslnfdouH2TkzH0SWz0Ic9EVH vddD0GOL+II/Qtxe+0s201n0GRnTdjO0xnTnp7sGKC6cOc4V7fwpvNeVWLyhLMOY r4J2Z5aZfcpR14lTwPToLQ44Ix6wd2QHbnV8KDUmHb93W7sJZzl3ATFDMQvuGLBT daygZQ2JBw44hVUeVu+H/mZyYKqpqXKkEVp5TmbrcVnS5xdMFvd5Uy8XPAMmRzVn E+OC5jmA7AzsabQHjyyUZY7rh4poIN5X59OVdxpc6LbsIh/Rc24KrPxVH5xTK4F2 xVP6BLrrZjN5WmXIEWhaqEFgIexmc9fRh7/KzyJ7MHva1DnKXyuu2jpH2RHRsEXb QXLknFdh2EyyZDoTrjCNRzh6BU3P9SQUgQF1ofJN0vfpVr+mMCHnorxGskmFQTwM 8V+T9Ma+W7bHwoqwoIH6BPT6IZvohccgm0wCaUvr9r8mkAndKFI= =cBwT -----END PGP SIGNATURE----- --beRCE4wAQu1NyZ2N--