Re: [PATCH v8 27/30] packet: remove PACKET_POOL() and PACKET_POOL_P()

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

On Tue, Aug 05, 2025 at 05:46:25PM +0200, Laurent Vivier wrote:
> These macros are no longer used following the refactoring of packet
> handlers to directly use iov_tail. Callers no longer require PACKET_POOL_P
> for temporary pools, and PACKET_POOL can be replaced by PACKET_POOL_DECL
> and separate initialization if needed.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  packet.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/packet.h b/packet.h
> index 7afe80ef3fcf..286b6b9994db 100644
> --- a/packet.h
> +++ b/packet.h
> @@ -59,19 +59,10 @@ struct _name ## _t {							\
>  	.size = _size,							\
>  }
>  
> -#define PACKET_POOL(name, size, buf, buf_size)				\
> -	PACKET_POOL_DECL(name, size, buf) name = 			\
> -		PACKET_POOL_INIT_NOCAST(size, buf, buf_size)
> -
>  #define PACKET_INIT(name, size, buf, buf_size)				\
>  	(struct name ## _t) PACKET_POOL_INIT_NOCAST(size, buf, buf_size)
>  
>  #define PACKET_POOL_NOINIT(name, size, buf)				\
>  	PACKET_POOL_DECL(name, size, buf) name ## _storage;		\
>  	static struct pool *name = (struct pool *)&name ## _storage
> -
> -#define PACKET_POOL_P(name, size, buf, buf_size)			\
> -	PACKET_POOL(name ## _storage, size, buf, buf_size);		\
> -	struct pool *name = (struct pool *)&name ## _storage
> -
>  #endif /* PACKET_H */

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]