From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=CUWbWKpW; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 2D5A25A028D for ; Wed, 06 Aug 2025 08:35:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1754462131; bh=+DBaRZy9AcSGSp0wh36BGuLIe/WE2IhqHFszvcJvocw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CUWbWKpWroTRJRYAw/JHPxzRBBtOPHxEd0DkFpDw/P+D8Ij6CEXMlqtJkL5FFKCqq pAbr+7D9SXwdOhCcHR16s/e4gOKBDc7WgGjrsbRk68lUrbXo8XkQuNu0UJyByEyHVF 1i8G9wwJ92ggs8H2hb2Xe4TFJB5Jmda/lmywgJfMPRwUxe3j6lm7eAf/I40+eey6/5 lQzON2d0iYEtRqw8xPyMHo3DMbRD0IUHyJ5eRQiLIuCWXu6a4EIuzJXKPi176OeJBW m2Dby6PONYdqqGy8Rk83/E1/oCJHY/pHxd2AyYy9vhtzOzAD5fQZXgjG1OMMyH2VHd 9+BC9V064LbfQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4bxgXM1jbBz4xd0; Wed, 6 Aug 2025 16:35:31 +1000 (AEST) Date: Wed, 6 Aug 2025 16:32:40 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v8 27/30] packet: remove PACKET_POOL() and PACKET_POOL_P() Message-ID: References: <20250805154628.301343-1-lvivier@redhat.com> <20250805154628.301343-28-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5NihLW4xRVU9nS9c" Content-Disposition: inline In-Reply-To: <20250805154628.301343-28-lvivier@redhat.com> Message-ID-Hash: UQ46RMFZC3XPN35H36XC7RQMHM4U5GY7 X-Message-ID-Hash: UQ46RMFZC3XPN35H36XC7RQMHM4U5GY7 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --5NihLW4xRVU9nS9c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 05, 2025 at 05:46:25PM +0200, Laurent Vivier wrote: > These macros are no longer used following the refactoring of packet > handlers to directly use iov_tail. Callers no longer require PACKET_POOL_P > for temporary pools, and PACKET_POOL can be replaced by PACKET_POOL_DECL > and separate initialization if needed. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > packet.h | 9 --------- > 1 file changed, 9 deletions(-) >=20 > diff --git a/packet.h b/packet.h > index 7afe80ef3fcf..286b6b9994db 100644 > --- a/packet.h > +++ b/packet.h > @@ -59,19 +59,10 @@ struct _name ## _t { \ > .size =3D _size, \ > } > =20 > -#define PACKET_POOL(name, size, buf, buf_size) \ > - PACKET_POOL_DECL(name, size, buf) name =3D \ > - PACKET_POOL_INIT_NOCAST(size, buf, buf_size) > - > #define PACKET_INIT(name, size, buf, buf_size) \ > (struct name ## _t) PACKET_POOL_INIT_NOCAST(size, buf, buf_size) > =20 > #define PACKET_POOL_NOINIT(name, size, buf) \ > PACKET_POOL_DECL(name, size, buf) name ## _storage; \ > static struct pool *name =3D (struct pool *)&name ## _storage > - > -#define PACKET_POOL_P(name, size, buf, buf_size) \ > - PACKET_POOL(name ## _storage, size, buf, buf_size); \ > - struct pool *name =3D (struct pool *)&name ## _storage > - > #endif /* PACKET_H */ --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --5NihLW4xRVU9nS9c Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmiS9v0ACgkQzQJF27ox 2GfhVRAAplJKJrCpBjwz6rbpjD6KXTJZxQ5LTffEnfnNr3kL0tw+M9ovvsT+Cryc qw/ClUz60A40Wg+28OXE+SoURxpa4a6xEcbiqOpLebwKrsfUBsZusGnjUkUST7+m BuUJRjTMwVBO8KjC0m5RgcgcNQSkoJCA2336fPla2b/0kBDjAen+z4BlbnAc99pk UWG2OZ5yuzAzw9ifBNz9HHuFcRvSgCuxw5A0Zp0fLug0KsMCwSuZzif6YR8F/7NF ys5iy6C3Habk+VAxq49Lvi5hS6bLExO9AOaomtD6hqR+c6KDhKW+CqBRZGk4Byoe nIp3+OfCSxvDd9HREivagTX7CkZDd3WOhOXRPfKfSOtfT6V6xgcNy+Ap+bFhi4ZB RUC/k5oA9GswbiKwqyRbx5V1btzl0uak1caqAJAeuWjb1mjgexS/kLmoeNdblL5c zDNE1n91KelMS1tyUVEcFGqMrj2gOXUI+FH1bsCRsw1ntZyiYySkTXS9dGVFP/1C WbtIyg3TVUmvmtdpVvhAmV+el9L7rQh68HEJh7Ol7Xm487hECnLolN+Qda4sL+CA e6qufhbXzRYpGIZ3PiDyYu1niM2g/9RdOO0yH6EJ/VSIy4skXNhTAep2W/NQUflH c1g1DeCJwxaKoPI7bKP8GSHjKPVpWxlkJhedRjvZdj57lSGuDjE= =Mf8c -----END PGP SIGNATURE----- --5NihLW4xRVU9nS9c--