From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=WuEE173u; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 7CD2F5A0271 for ; Thu, 07 Aug 2025 13:47:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1754567223; bh=WUiVu+YJPE8/8m/Xo8/KR1V4DZJFzkIl77Yrc52nXdQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WuEE173uA0q8qdYhlH5PE301CBHn3HrFY75VAqY4wCq+mOvKpGCPu/UpFB+EpFeoX qA6rAIliG8oWgvN7djTF2q7wFDyPa2Drbym2qkTnk9wl1Axq8NX1Fkh3U73lzcyf96 h5aMIAjKuPW8ZK48j4WGeDYwlVhgKi3vrUT7OC40GppaTNCCPeukthRMd2e3Zj95kj 7+mo3oDJeo/s5jtVma8ygK8KTVHpbweV+EfX3RuVyTZcPJX+ZEydaRj1j1uUAhmbKU UwHbG7XyaoMTy+/InbOLivEj6dI2a3ZP0A+jgc8eagBsYWbUL9CJJzM3/Gm77a4kL0 X/sTXOYacpuHg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4byQPM34gxz4wd0; Thu, 7 Aug 2025 21:47:03 +1000 (AEST) Date: Thu, 7 Aug 2025 21:44:16 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v8 29/30] packet: Refactor vhost-user memory region handling Message-ID: References: <20250805154628.301343-1-lvivier@redhat.com> <20250805154628.301343-30-lvivier@redhat.com> <6b6b3834-76a1-449c-93ca-ec6fdea2c84f@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H6YYKe2nJXktOHCP" Content-Disposition: inline In-Reply-To: <6b6b3834-76a1-449c-93ca-ec6fdea2c84f@redhat.com> Message-ID-Hash: DSDUKJ463XOISRLVL5LR5WGOB4HU2PHM X-Message-ID-Hash: DSDUKJ463XOISRLVL5LR5WGOB4HU2PHM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --H6YYKe2nJXktOHCP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 07, 2025 at 11:05:46AM +0200, Laurent Vivier wrote: > On 07/08/2025 08:10, David Gibson wrote: > > > @@ -437,12 +437,12 @@ static bool vu_set_mem_table_exec(struct vu_dev= *vdev, > > > r->size + r->mmap_offset); > > > } > > > } > > > - vdev->nregions =3D memory->nregions; > > > + vdev->memory.nregions =3D memory->nregions; > > > debug("vhost-user nregions: %u", memory->nregions); > > > - for (i =3D 0; i < vdev->nregions; i++) { > > > + for (i =3D 0; i < vdev->memory.nregions; i++) { > > > struct vhost_user_memory_region *msg_region =3D &memory->regions[= i]; > > > - struct vu_dev_region *dev_region =3D &vdev->regions[i]; > > > + struct vu_dev_region *dev_region =3D &vdev->memory.regions[i]; > > > void *mmap_addr; > > > debug("vhost-user region %d", i); > > > @@ -484,13 +484,7 @@ static bool vu_set_mem_table_exec(struct vu_dev = *vdev, > > > } > > > } > > > - /* As vu_packet_check_range() has no access to the number of > > > - * memory regions, mark the end of the array with mmap_addr =3D 0 > > > - */ > > > - ASSERT(vdev->nregions < VHOST_USER_MAX_RAM_SLOTS - 1); > > > - vdev->regions[vdev->nregions].mmap_addr =3D 0; > > > - > > > - tap_sock_update_pool(vdev->regions, 0); > > > + ASSERT(vdev->memory.nregions < VHOST_USER_MAX_RAM_SLOTS); > > It looks like the assertion is changing threshold by one, and I'm not > > sure why. >=20 > It's because previous version was using the last slot to mark the end of = the > array with a NULL memory region. Now, we have a counter, it's not needed > anymore. Ah, ok. Might be worth mentioning that in the commit message. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --H6YYKe2nJXktOHCP Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmiUkYAACgkQzQJF27ox 2Gf04RAApQdAn9VceeOXNEeB5IeZSgB0+4aNi1UYPWyuIxY5zIbMOSEFDLdLfvaq w4m4mxx1IcLW2u/2BqbMCbEQ5oWLRjW7VRO3vWTxEJ+ZMqHyxDh80euXBxRDJErx UH1nVDTTFf5XSS67HpMWZVRSZBffPoW2lSjw4yC9ON4C0QULqC0ZLVlhnlv2DHwY Z+1onEUNGqxgj+EaVlCmKJiWmb0daw34KHyxWeGd/YoPugG2WDB6NynxNxIkmzri OHMM8YaCW0vvnXuDH+vAGiBSWiNduTSjO5g8a2NPaMuop0ZARt0kWYIIg+CqPvvD EO+YeTZpI/lYshUMpn/tmiMpJ4xG74IcT1E0I8b586N3OSj3qMnYGlKwUE9gqD+R 8P8XyP5k38CV7DLR/CSbbVNIS2BOnUWIkBnVldlFRY4fUEbj2Tp3tRtyGrP/qzzT sRx6aiiIQnlVFiS/Wen62MYf6xifLZs0P8tIqS7HzADoAY7BNvTEPp3jNFZ01nin ZZePJn2AppcRjSUK2czhZEqPTZJd8m0kC+5SaI9XHkOzlM93tHMHCP2cPMlh0oNj 1YwLmO7YdZHto45dZBC+sxe6ZKNaPjXXjd+Wm+1yQIgaupbHtjIh6FMGg1z9kpKx 6NTrINYGcTzJHBJEBCpru8I0zJ9GH/nMUDr8jvXYV9GvIu3uqQE= =3Ma4 -----END PGP SIGNATURE----- --H6YYKe2nJXktOHCP--