From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=P3LrdBEz; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id C9B645A027A for ; Wed, 13 Aug 2025 04:29:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1755052167; bh=POMa8sHOKbpPO6DAGTDWu59q46USIQ+QRykQD+rdk5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P3LrdBEzsZG87Iw5nRzUPEkz1MsyJ3Z2G5wFS9mFpXreNm2gLbU6gO+zL7f94YFhZ Rawxv6vpfyR4x57VFlEsYy9xXoNxTlX8MDzrqno+UftRbF4AoGXpRfFVbjGGE1RB3L 8PXrF+9df/q3Qhec3OVaeayb1Ls4W7WGAGb3N3Tg9vlouAxSOK4TljvBmL0qaw+hPk V08uQ1azDmKqGONlDAB4C96hH0LbSMCtkNWAEQhTsMRDj3qMA+HtsutgQw/6YyiYf6 0a1J0oTgk4x4S69lfjD+vYeIQGUNsyBpEv02tZMVTtqcaeJKJySyx9UijQmAxmHCg4 PTBcPaj1KcOFw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4c1slC5G6fz4x6J; Wed, 13 Aug 2025 12:29:27 +1000 (AEST) Date: Wed, 13 Aug 2025 12:29:22 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v8 16/30] dhcpv6: Use iov_tail in dhcpv6_opt() Message-ID: References: <20250805154628.301343-1-lvivier@redhat.com> <20250805154628.301343-17-lvivier@redhat.com> <29eeceb3-87a8-42d7-a95d-5be6b8d97478@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="06HL7uiSdbmwcVu+" Content-Disposition: inline In-Reply-To: <29eeceb3-87a8-42d7-a95d-5be6b8d97478@redhat.com> Message-ID-Hash: FGM2M43PE4LRDWZZVXS5VNLSR6KVIFO7 X-Message-ID-Hash: FGM2M43PE4LRDWZZVXS5VNLSR6KVIFO7 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --06HL7uiSdbmwcVu+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 08, 2025 at 03:59:51PM +0200, Laurent Vivier wrote: > On 06/08/2025 06:14, David Gibson wrote: > > On Tue, Aug 05, 2025 at 05:46:14PM +0200, Laurent Vivier wrote: > > > dhcpv6_opt() and its callers are refactored for iov_tail option parsi= ng, > > > replacing direct offset management for improved robustness. > > >=20 > > > Its signature is now `bool dhcpv6_opt(iov_tail *data, type)`. `*data`= (in/out) > > > points to a found option on `true` return or is restored on `false`. > > > The main dhcpv6() function uses IOV_REMOVE_HEADER for the msg_hdr, th= en > > > passes the iov_tail (now at options start) to the new dhcpv6_opt(). > > >=20 > > > Signed-off-by: Laurent Vivier > >=20 > > Hmm. I'm not sure this is a great use case for iov_tail - the code is > > repeatedly scanning the same options, so there's a whole bunch of > > rewinding. It works, but it seems awkward. > >=20 > > DHCP is a slow path, anyway, so maybe we'd be better off just > > linearizing the entire packet and using plain old pointers to scan > > through the options. > >=20 >=20 > Well, I'd like to avoid to rewrite this patch as it has a lot of > changes. Yeah, fair enough. > But if you think it's really needed I will do in a new version of > the series. No, I don't think it's important enough. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --06HL7uiSdbmwcVu+ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmib+IEACgkQzQJF27ox 2GdYaQ/+OaCumKSxOOVCC5UngBml2YuPB4julUWX+8AYomKsJunyOjyitm//vP1w VKZFpWP9M/qotvN2jM2VRg7jpVPK9uYplyqbbKDkxjo/aVeGgzaUjR/t3CBGqwV5 nVDSoAR9Xkt68BoQmYBvgKV9p0NJeL7eq+c+h7Bqof8JHHJ0ld8Pwx5dgT90yzkj UxXu2JmcDw1u+KTmqNlHppjgOkmXnuw6IdswZyj3TjSMX3kYlAdHoGLtpsB6dDeI bnaQ/08GpXewHxQRsQuHVmZhCGKET37fhRfdPDL/l3Vn/bglvnSXdKL+VqDJlIoj rr7yw3wDlifeAzAm1WXR6Li+menuFLO0drMhSlKgUGqbxAhswZAsVlqqwTu5lSv0 23vUvf2OXT0VqrIKMSfjyR2f16Z6NFzfcINA0dxiBgVB6RzIg6kLXHA8BqCIAau9 CuP3ytgWp28Flciu3wC63XRqZpDW9hvmi0L9n1NSdtdTnb7fVbHhzzznNoR6834L 5Y2pGX80TJRfS30Ed/ifmFuHq2h1W81PXsBDizUcABAvnDCylF1IuOgcoJ4b4/b8 A8lJ844fqVuSa3BFWLYHEegp5UgKSgI0Sl2NkcQ4BKcJBszOtIlofZTFGOdMblrx j7KWefFR8cEQmkSeGuu/xGyl1EXDosyoXiCbNnUxsK02NTMXbpU= =q2Yc -----END PGP SIGNATURE----- --06HL7uiSdbmwcVu+--