Re: [PATCH v9 30/30] packet: Add support for multi-vector packets

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

On Fri, Aug 08, 2025 at 04:01:42PM +0200, Laurent Vivier wrote:
> The packet pool was previously limited to handling packets contained
> within a single buffer.
> 
> This patch extends the packet pool to support iovec array,
> allowing a single logical packet to be composed of multiple iovec.
> 
> To accommodate this, the storage format within the pool is modified.
> For a multi-vector packet, a header entry is now stored first with
> iov_base = NULL and iov_len holding the number of subsequent
> vectors. The actual data vectors are then stored in the following
> pool slots.
> 
> The packet_add_do() and packet_get_do() functions are updated to
> manage this new format for storing and retrieving packets. The
> pool_full() check is also adjusted to ensure there is enough
> space for all vectors of a new packet before adding it.
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

I think you posted this before I sent my review comments on v8 of
these last two patches.  As such my comments from v8 still apply here.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]