From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=Hu+tXqUK; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 55FBE5A028D for ; Wed, 13 Aug 2025 05:27:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1755055626; bh=Ak0NsYyAmyT3SL+/kJUn/+QOPgNKMJZkqHNb/Yw4yJY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hu+tXqUKZJQ0Ve6I2DCfxkIntAVc7Jz+bpuw9ZQJF2S3Wx/aVm3VASoe0gab9XU3G v7EOG4NQqMi4wu9vzSd00xWWfvBsq7hPVtjaetatNAWZG0iUoJ2u+Jc5CuYnmvKf3z l6Nx95VJpJXhUnxmFxTpruzn47LEFKCRdWVFiE0AsIrdCkdOUm6un2tny/5AkOVdiS YFTb5QavUXq2F1WJea14lI64WNSjdVTeh9/qy+hq8mEVOIzCAKWLNeMLj8FUQRYz4o 0DG0djomfxsnsRHyRPOpXKF/iByLpOHz34Uk3czzLnP349retlNqZN6W+638Px3fP6 +/hhwEgXMqGzA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4c1v1k5vgmz4xf6; Wed, 13 Aug 2025 13:27:06 +1000 (AEST) Date: Wed, 13 Aug 2025 13:26:59 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v9 30/30] packet: Add support for multi-vector packets Message-ID: References: <20250808140142.3404325-1-lvivier@redhat.com> <20250808140142.3404325-31-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8mtYykpu/WzFmqsi" Content-Disposition: inline In-Reply-To: <20250808140142.3404325-31-lvivier@redhat.com> Message-ID-Hash: LVR52ZUJBCTE7U2DSWZLII2FTSMYNKIZ X-Message-ID-Hash: LVR52ZUJBCTE7U2DSWZLII2FTSMYNKIZ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --8mtYykpu/WzFmqsi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 08, 2025 at 04:01:42PM +0200, Laurent Vivier wrote: > The packet pool was previously limited to handling packets contained > within a single buffer. >=20 > This patch extends the packet pool to support iovec array, > allowing a single logical packet to be composed of multiple iovec. >=20 > To accommodate this, the storage format within the pool is modified. > For a multi-vector packet, a header entry is now stored first with > iov_base =3D NULL and iov_len holding the number of subsequent > vectors. The actual data vectors are then stored in the following > pool slots. >=20 > The packet_add_do() and packet_get_do() functions are updated to > manage this new format for storing and retrieving packets. The > pool_full() check is also adjusted to ensure there is enough > space for all vectors of a new packet before adding it. >=20 > Signed-off-by: Laurent Vivier I think you posted this before I sent my review comments on v8 of these last two patches. As such my comments from v8 still apply here. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --8mtYykpu/WzFmqsi Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmicBgIACgkQzQJF27ox 2Gc7BxAAkwuNXNfBr3zPp1wmE8k3ThYsdhLR+J08ZIMtdIgKrdIf2HlXfpTaN0QT iQfwl3TGkQW0LJGWTmng8OVJqkagx33aN6zqTceCvR6L9Pzl6USKdDDLVoJurvYT Ahe+/J4Ytu1mhlkGe95jFGd6ULSETrVfmjWrjeufog7YaL/JMISdTbWT+V29GKMw TgbfUlztnImdc6Tc4wbjIJakklk9mE+q4jAotEexyMxuJ/Ch1ZSGR9EYNaQE1Ili xqU/Ibq9YmzPg+A6KQjK0zYVQ56Ar5oppmClyaegWn5t0y4AiiOgKl0tq2UaIWYI aaMQUJbqeWd5hyqdjz0GqFFjbQxgyxjPRhtwq+2gVwxEWf4fEZiH4HmjSNyw6pBG Ec8xD7IkN8E4vLtvCieL2oOvxtZsORmkQsMqfRSnAc/HCmBxVk0A5Kpr3VwkHmFU 4q83diYepAtgwTmtjROyjdsEamEeLAxxU2zhZSFSfMjbQepEi18jkrqqsuN2mZvN ruLtVTYeUnubKyuDFnGTSfNrnfzRS6nxcbNM0fZU/YmkdEeGI/5y7kfd0T8Lx5+x cVZiTm089EuKrdkl2cZThSCE6Yb1TgosnwpZY4KQq79heb2eLCvrAuWDsRDZ0x5C 29/U2kdLCfLHn1mevNp9tepFJFUBH7mmfGEGYiEQ7W/kdgkGO9s= =B6LY -----END PGP SIGNATURE----- --8mtYykpu/WzFmqsi--