From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=MRXjPeC0; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id D985D5A0279 for ; Thu, 21 Aug 2025 02:27:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1755736038; bh=M0tQ3FiOVEmxPGZdC6Mk7/RdtwsLY9h4E4sHb9rFOY8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MRXjPeC0r0BmWqCLbF0fgN9NfrS1knqm6Qg0B78+iEJ9cqd/94JX2FBrQcIzJVY9i XzfYNrKbOgQhJKh488Elfjzmz8XAu1vTqMfXMn1kYQjAbcv54skYubI2ADjC/fikU2 j59OunO/X6+2rYJ3KNyzqGO9lg3xjTOLkNSGQiy06sNZRn0I5aUeMJUbTORPr+eRnZ DohK9hDCEHZxzsRIA0pYeWo1YTEiQFnSdkTtZ/ap4jmygmXRbVyEgD5LvHfUcokI2Q tYoLsZt0yts0bR3eYCChXpmInXzKOrE4KJzEQEuRStnvkNLQ0VltmKbiChZLYUq+KT JU9NaeAXmDq2Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4c6kfZ2qdhz4wbr; Thu, 21 Aug 2025 10:27:18 +1000 (AEST) Date: Thu, 21 Aug 2025 09:31:01 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v4 1/3] test: Extend test scripts to allow running exeter tests. Message-ID: References: <20250807113237.548294-1-david@gibson.dropbear.id.au> <20250807113237.548294-2-david@gibson.dropbear.id.au> <20250819162738.36d35d52@elisabeth> <20250820115218.2cdab1ba@elisabeth> <20250820134427.6a16ad19@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UOc1njKlK9EFsvHM" Content-Disposition: inline In-Reply-To: <20250820134427.6a16ad19@elisabeth> Message-ID-Hash: KGRJL6KPQGM63AYHMUMVDZUYNBJOCNBM X-Message-ID-Hash: KGRJL6KPQGM63AYHMUMVDZUYNBJOCNBM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --UOc1njKlK9EFsvHM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 20, 2025 at 01:44:27PM +0200, Stefano Brivio wrote: > On Wed, 20 Aug 2025 21:10:17 +1000 > David Gibson wrote: >=20 > > On Wed, Aug 20, 2025 at 11:52:18AM +0200, Stefano Brivio wrote: > > > On Wed, 20 Aug 2025 12:55:58 +1000 > > > David Gibson wrote: > > > =20 > > > > On Tue, Aug 19, 2025 at 04:27:38PM +0200, Stefano Brivio wrote: =20 > > > > > On Thu, 7 Aug 2025 21:32:35 +1000 > > > > > David Gibson wrote: > > > > > =20 > > > > > > Introduce some trivial testcases based on the exeter library. = These run > > > > > > passt and pasta with --help and --version options. Extend our = test > > > > > > scripts to run these tests. > > > > > >=20 > > > > > > Signed-off-by: David Gibson > > > > > > --- > > > > > > test/.gitignore | 1 + > > > > > > test/Makefile | 5 ++++- > > > > > > test/lib/exeter | 46 +++++++++++++++++++++++++++++++++++++= ++++++++ > > > > > > test/run | 9 ++++++++- > > > > > > test/smoke/smoke.sh | 27 ++++++++++++++++++++++++++ > > > > > > 5 files changed, 86 insertions(+), 2 deletions(-) > > > > > > create mode 100644 test/lib/exeter > > > > > > create mode 100755 test/smoke/smoke.sh > > > > > >=20 > > > > > > diff --git a/test/.gitignore b/test/.gitignore > > > > > > index 3573444f..cf48b885 100644 > > > > > > --- a/test/.gitignore > > > > > > +++ b/test/.gitignore > > > > > > @@ -11,3 +11,4 @@ nstool > > > > > > rampstream > > > > > > guest-key > > > > > > guest-key.pub > > > > > > +/exeter/ > > > > > > diff --git a/test/Makefile b/test/Makefile > > > > > > index bf63db87..332f3f3e 100644 > > > > > > --- a/test/Makefile > > > > > > +++ b/test/Makefile > > > > > > @@ -50,7 +50,7 @@ UBUNTU_NEW_IMGS =3D xenial-server-cloudimg-po= werpc-disk1.img \ > > > > > > jammy-server-cloudimg-s390x.img > > > > > > UBUNTU_IMGS =3D $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS) > > > > > > =20 > > > > > > -DOWNLOAD_ASSETS =3D mbuto podman \ > > > > > > +DOWNLOAD_ASSETS =3D exeter mbuto podman \ > > > > > > $(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS)= =20 > > > > >=20 > > > > > Pre-existing, but this broke a while after you switched the image > > > > > preparation to Makefile targets, so you can't really expect peopl= e to > > > > > issue 'make' at the moment. =20 > > > >=20 > > > > Sorry, I'm not quite sure what the problem is you're getting at. = =20 > > >=20 > > > This: > > > -- =20 > >=20 > > Hm, could you avoid using -- to mark quotes like this. mutt mistakes > > it for the sig and cuts it out; it's kind of a pain to paste it back > > in for repying. >=20 > Oops, weird, because that was originally "--\n", without a space: Yes, that's what I see too. > https://en.wikipedia.org/wiki/Signature_block#Standard_delimiter Yeah, I know. I guess mutt considers it the delimiter even without the space, since it's pretty easy to miss. > In your quote that has now three spaces. Is it a bug in mutt? I never > hit it though (but I almost exclusively use claws-mail). Maybe? At least, I think it's a mutt behaviour. It's possible it could be emacs post-mode. > Would "---\n" avoid that? I think so. > > > $ mkdir psst > > > $ cd psst > > > $ git clone git://passt.top/passt > > > [...] > > > $ cd passt/test/ > > > $ make > > > [...] > > > wget -c -O debian-11-generic-ppc64el.qcow2 https://cloud.debian.org/i= mages/cloud/bullseye/latest/debian-11-generic-ppc64el.qcow2 > > > --2025-08-20 11:27:05-- > > > https://cloud.debian.org/images/cloud/bullseye/latest/debian-11-gener= ic-ppc64el.qcow2 > > > Resolving cloud.debian.org (cloud.debian.org)... 2001:6b0:19::165, > > > 2001:6b0:19::173, 2001:6b0:19::163, ... > > > Connecting to cloud.debian.org > > > (cloud.debian.org)|2001:6b0:19::165|:443... connected. > > > HTTP request sent, awaiting response... 404 Not Found 2025-08-20 11:2= 7:05 ERROR > > > 404: Not Found. =20 > >=20 > > > make: *** [Makefile:150: debian-11-generic-ppc64el.qcow2] Error 8 =20 > >=20 > > Ah, right. All the distro wgets are so slow from Australia that I've > > always avoided them by keeping the image files in place (or even > > copying the back from backups). So, I didn't hit this. Yeah.. we > > should do something about that. > >=20 > > > The (very) old logic would make the "distro" tests fail, but it's > > > been a while that one can't really run 'make' under test/ anymore > > > (unless you have everything already prepared, that is). =20 > >=20 > > > On one hand, we don't have a replacement for those tests, and, while > > > ugly and clumsy, they were actually useful as they would have told > > > us > > > in advance about stuff such as: =20 > >=20 > > > https://bugs.passt.top/show_bug.cgi?id=3D121 =20 > >=20 > > > ...and probably much more that we're ignoring now. I don't even test > > > routinely on big-endian, we just have build tests from > > > distributions. That's bad, and it will be ages before we can > > > reasonably get a replacement for that. =20 > >=20 > > Yeah. On the other hand, we could at least remove the links that are > > actually broken. The idea of testing across distros seems to me more > > important than the exact set of distros/versions to check - that's > > relatively easily expanded if we have the structure. >=20 > ...or find alternate links / similar versions. Older versions are > important, too. For that one, this looks like a stable link: >=20 > https://cdimage.debian.org/cdimage/cloud/bullseye/20250703-2162/debian-= 11-generic-ppc64el-20250703-2162.qcow2 Right. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --UOc1njKlK9EFsvHM Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmimWqcACgkQzQJF27ox 2GdkfhAAjAU+RLZRtpmDV4b6tqNlWvfCOvssA2y1XWITBSZw4LtoskI1yPOWalx7 5mYc/CKW7RShcw6XjKdR+YBagHEp1tUxsATVf9GnaCqdklG83zqH5lPbr0Vm3sYH 2ayqygIEFfdKsjoWziS8tJrJXA6u9Vk6PP8q8yQR6H08I+mrPZVBwy0nJmsZq/l3 GbZZ8u9yajZW+XvZlqybZG6SSFfd2l5SFAyK5N6il63lHprAxWmrzeReGs0UUvnE ErCIk43bnQEpPa5lFyqwgehEy2eF9FvQbCNZGP+WyaRb5jUmbHBIcXcb2rFtIvDH BuFGAIhitN0wYUJcJWLojC+43IUSr4dyNlyQb2pa4k9s8mPBYc1QJzhCLv2yjlJu Drz5ksikfwq2tFeh6pSn6+CXEV3/t/qilqayriA1ORSIdJhiIUx/NdsI2CP0G1jO 4w3OE4R9JkXbuAiAPZSUJ1JEvjzKyV2srbwQso2GRR2FzIDSEqpjVZy/zft9NvBH rc4laVXzHg6suHdFLuUNp1IO7M5c7aNMgmw8+Cck2jZgnrYVZZ6VtyFFes/CyUXD T1p/DQZ8cprIc28KTWciZuRtiJI/sNaL7f6y89JzdEuCEHbBLderaSWdEOqHQoIa I85ZCJtmahEmFM4XEEKHNCEs9IMOpiH/XTplvYfEmKxRrTk6Ktc= =G/SR -----END PGP SIGNATURE----- --UOc1njKlK9EFsvHM--