Re: [PATCH v4 1/3] test: Extend test scripts to allow running exeter tests.

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 4433 bytes --]

On Thu, Aug 21, 2025 at 11:26:59PM +0200, Stefano Brivio wrote:
> On Thu, 21 Aug 2025 09:31:01 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > On Wed, Aug 20, 2025 at 01:44:27PM +0200, Stefano Brivio wrote:
> > > On Wed, 20 Aug 2025 21:10:17 +1000
> > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > >   
> > > > On Wed, Aug 20, 2025 at 11:52:18AM +0200, Stefano Brivio wrote:  
> > > > > On Wed, 20 Aug 2025 12:55:58 +1000
> > > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > > >     
> > > > > > On Tue, Aug 19, 2025 at 04:27:38PM +0200, Stefano Brivio wrote:    
> > > > > > > On Thu,  7 Aug 2025 21:32:35 +1000
> > > > > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > > > > >       
> > > > > > > > Introduce some trivial testcases based on the exeter library.  These run
> > > > > > > > passt and pasta with --help and --version options.  Extend our test
> > > > > > > > scripts to run these tests.
> > > > > > > > 
> > > > > > > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > > > > > > > ---
> > > > > > > >  test/.gitignore     |  1 +
> > > > > > > >  test/Makefile       |  5 ++++-
> > > > > > > >  test/lib/exeter     | 46 +++++++++++++++++++++++++++++++++++++++++++++
> > > > > > > >  test/run            |  9 ++++++++-
> > > > > > > >  test/smoke/smoke.sh | 27 ++++++++++++++++++++++++++
> > > > > > > >  5 files changed, 86 insertions(+), 2 deletions(-)
> > > > > > > >  create mode 100644 test/lib/exeter
> > > > > > > >  create mode 100755 test/smoke/smoke.sh
> > > > > > > > 
> > > > > > > > diff --git a/test/.gitignore b/test/.gitignore
> > > > > > > > index 3573444f..cf48b885 100644
> > > > > > > > --- a/test/.gitignore
> > > > > > > > +++ b/test/.gitignore
> > > > > > > > @@ -11,3 +11,4 @@ nstool
> > > > > > > >  rampstream
> > > > > > > >  guest-key
> > > > > > > >  guest-key.pub
> > > > > > > > +/exeter/
> > > > > > > > diff --git a/test/Makefile b/test/Makefile
> > > > > > > > index bf63db87..332f3f3e 100644
> > > > > > > > --- a/test/Makefile
> > > > > > > > +++ b/test/Makefile
> > > > > > > > @@ -50,7 +50,7 @@ UBUNTU_NEW_IMGS = xenial-server-cloudimg-powerpc-disk1.img \
> > > > > > > >  	jammy-server-cloudimg-s390x.img
> > > > > > > >  UBUNTU_IMGS = $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS)
> > > > > > > >  
> > > > > > > > -DOWNLOAD_ASSETS = mbuto podman \
> > > > > > > > +DOWNLOAD_ASSETS = exeter mbuto podman \
> > > > > > > >  	$(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS)      
> > > > > > > 
> > > > > > > Pre-existing, but this broke a while after you switched the image
> > > > > > > preparation to Makefile targets, so you can't really expect people to
> > > > > > > issue 'make' at the moment.      
> > > > > > 
> > > > > > Sorry, I'm not quite sure what the problem is you're getting at.    
> > > > > 
> > > > > This:
> > > > > --    
> > > > 
> > > > Hm, could you avoid using -- to mark quotes like this.  mutt mistakes
> > > > it for the sig and cuts it out; it's kind of a pain to paste it back
> > > > in for repying.  
> > > 
> > > Oops, weird, because that was originally "--\n", without a space:  
> > 
> > Yes, that's what I see too.
> > 
> > >   https://en.wikipedia.org/wiki/Signature_block#Standard_delimiter  
> > 
> > Yeah, I know.  I guess mutt considers it the delimiter even without
> > the space, since it's pretty easy to miss.
> 
> It doesn't for me, and also judging from the implementation:
> 
>   https://gitlab.com/muttmua/mutt/-/blob/5fd040e3aa1f807db1cab4ca7d7ba5fc8d48722e/rfc3676.c#L295
> 
> it looks like it's done properly.
> 
> > > In your quote that has now three spaces. Is it a bug in mutt? I never
> > > hit it though (but I almost exclusively use claws-mail).  
> > 
> > Maybe?  At least, I think it's a mutt behaviour.  It's possible it
> > could be emacs post-mode.
> 
> The latter sounds more likely to me. I'm not sure what you can
> configure in Emacs though.

Aha!  Looks like it is that.  Finally managed to figure it out.
post-signature-sep-regexp was wrong... but changing it didn't seem to
fix things.  Brute force turning off post-kill-quoted-sig did the
trick.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]