From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=wXp+gVXV; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 57E245A0271 for ; Mon, 08 Sep 2025 04:00:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1757296826; bh=gM2z/0mQApZFLWIfZfLF4fuokkG8FLN8FttJ0VD0eS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wXp+gVXVoLj3hTjPL9kJiBEQte5Oj4D2+E/gqSYk9oGSz201H6n3VBDypsvL9lGRF DpzRYSTeoptgKqblZ+k+hc7kp5B+gnaLXvA4PQUpJrflajeN/vjbbcdamvbMp95oaV uupMxoO7zJgIvWHTpq0Y2KkVoBN0kWPUgQvpRJppJhZH+luOmRpOec1UTvDTigChoH yWmpppiiUjr6IzpZE9+3lS0wlKv0dN1mlDy3G7Tho3cASENThVoOzKbbZF5UFr963w aD34MmiZbCNZjtCWoqcweLzb6UQLAwiuwkPEHnHLSIGy1g9TBjiRJ143bkcMYSEBMV SZz28A4shdnfQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cKqsk1cC5z4wBD; Mon, 8 Sep 2025 12:00:26 +1000 (AEST) Date: Mon, 8 Sep 2025 11:52:50 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v7 0/4] Introduce first exeter based test infrastructure Message-ID: References: <20250904025004.491185-1-david@gibson.dropbear.id.au> <20250905011433.41c0d242@elisabeth> <20250905130154.76bd6329@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xyfpcHO7k60g4gXd" Content-Disposition: inline In-Reply-To: <20250905130154.76bd6329@elisabeth> Message-ID-Hash: FCPZDV5NEMJCKJNETARC7RAK7EJHK6SA X-Message-ID-Hash: FCPZDV5NEMJCKJNETARC7RAK7EJHK6SA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --xyfpcHO7k60g4gXd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 05, 2025 at 01:01:54PM +0200, Stefano Brivio wrote: > On Fri, 5 Sep 2025 16:42:58 +1000 > David Gibson wrote: >=20 > > On Fri, Sep 05, 2025 at 11:35:53AM +1000, David Gibson wrote: > > > On Fri, Sep 05, 2025 at 01:14:33AM +0200, Stefano Brivio wrote: =20 > > > > On Thu, 4 Sep 2025 12:50:00 +1000 > > > > David Gibson wrote: > > > > =20 > > > > > Here's a new approach to building passt tests with exeter. This = new > > > > > one no longer uses Avocado in the default case, although it would > > > > > still be possible to manually run the exeter based tests with Avo= cado. > > > > >=20 > > > > > For now this only does simple tests, to show how the integration = could > > > > > work. It adds some new trivial "smoke tests" and converts the li= nter > > > > > and build checks to exeter. More complex tests will require buil= ding > > > > > the tunbridge library we've discussed. A lot of the work for that > > > > > already exists in my earlier exeter test series, but it will need= some > > > > > rework to split it into a separate component. > > > > >=20 > > > > > v7: > > > > > * Use "exetool list" rather than "--list" directly to get test m= anifest. > > > > > * Update Makefiles to automatically update exeter sources as nec= essary. > > > > > * Update series cover letter removing some outdated information.= =20 > > > >=20 > > > > I was about to apply this, but then realised that the usual build t= est > > > > links at https://passt.top/#ci disappeared, see also > > > > https://passt.top/builds/latest/web/ci.js. =20 > > >=20 > > > Huh, that's weird. > > > =20 > > > > I didn't really investigate > > > > yet, we're missing something equivalent to the "test" directive. = =20 > > >=20 > > > We shouldn't be. exeter() calls status_test_{start,ok,fail} much like > > > test(). =20 > >=20 > > Ah.. but I didn't call video_link, like test_one() did. Which > > explains why the new tests weren't getting links... but not why it > > broke the existing ones. >=20 > No, no, existing ones are fine. Just the *build* test links were > missing. It all works now (with v8). Ah, ok. > > Well, I've put that in, and ci.js looks sane to me, but I don't really > > know how that video stuff works. I'll send v8. >=20 > It's write-only code but it's conceptually simple: we record the start > timestamp (based on /proc/uptime) of each test file and add that, > together with a key, to a JavaScript array, video_cilinks. >=20 > One 'a' HTML element (link) is also generated for each test file, with > an 'id' attribute matching that key, and when you click on that link, a > listener will look into video_cilink and use the matching start > timestamp as seek time for AsciinemaPlayer. Right. I pretty much figured that out as I was looking at it. > > > > If I > > > > recall correctly, that was working in v5, but I'm not sure why. I s= till > > > > need to look into this, unless you figure it out meanwhile. =20 > > >=20 > > > Right, you said v5 worked. Hrm.... one of the main differences since > > > v5 is getting the descriptions, which *are* used as the parameter to > > > status_test_start. Could the descriptions be using some character we > > > weren't before and we're missing an escape somewhere? Not seeing an > > > obvious spot. >=20 > I guess I didn't actually recall correctly, or didn't check those > links, because it couldn't have worked in v5 either. Right. I'd also discarded this theory in the meantime. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --xyfpcHO7k60g4gXd Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmi+Nu0ACgkQzQJF27ox 2GfgKQ/+Jw1YZfQaaoS2vvs6DDDXflbu4410xzstPpz85b+5IcVfX6H7M0kMAy+0 4eS1XBfYPe+lym+Cq7G0QJdDI6zTUb2yVfvpDuI2FZAeOCBnBXYM209Axv3c9nSY V/HuB6QBsc5CyB/sP6Z2U2l9VP6q+0gjmtpxOMK/O7O/g1nJPHu02dVBAgIdroz+ fCIYowrJ38Um9OkgKyJeb61Nrdzy5C2/vz7Cl6qA66c71gl7c3CutKCTld3XT+eR xFxsMDMFhOtGAUfgL2sref4QaHFPhWfOx7tbSSile4l3yyzQlKDdy728h8CH/nYf 549s6FIzDUavpq4OJ/jwgplkahsK+rnzBPZ5SKMcokvV83Gabv9e4Hp9WDXfL5Al Zhq1DbjRn5ESTYXZhhFydVSGXz9N+yT0xbGeCJrU5sPnRlmK/uM9NwHaSXd90NwJ AU8/D+8bcFi7Uqcrbb+Ivioyfr6/7vw89tAITkLWNT4SUTVia+9swLKi9QlmShLw B1EchkvOj0WST8TcofGNy1Z0d34ispuGVkwQlSZQR+VGwWClNrVcOrQVIAOM3mWY DmOjKTGjFGqhHYzyHNlk50Lzfr0ZOENmp6IRFKNt3Be3gLwhXMvtdniF6SWbQakT BRCBQiCqXQPcgZNjeBOzICPgQ6seNO8fAraPhgv45UmoZeLdlhs= =dePI -----END PGP SIGNATURE----- --xyfpcHO7k60g4gXd--