From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=vNEi/fzo; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 776735A027A for ; Mon, 08 Sep 2025 04:00:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1757296826; bh=7E7ob53pm/ry9ktz5ixil9l/NjNY3tJYVcCkt6zJy3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vNEi/fzoEESSlMkjY9mw5XRR3Zy43sw63c/+wscz6ZvmE2ksMPYuFk7c9LqNKru/I pM8YCV1G0zvQemMmQTFjM/ZMZ8LI4aGguWzYtIIp1pLFIshgEI3zL5RuGNGjgjBny7 99frD1JNG9EDoFO8hQsPNPaAQt1gEc2vPy4yF6ZS02Y4zw8vX3n65TpqUdhKh9hNvA oaN/a5M7QKK1WB4G1T3xh5xXJO2TYVMQSShPOnW+wE/WCh1EQUP+F35UpR/LRXvLFZ CT6kzo+8phn4vmgNoaRkHxFLGJb1K8M0yED/ZWSz47GCaung6He7F0YRMg817P6okP iTzKKX6RM0f5A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cKqsk1nvdz4w9y; Mon, 8 Sep 2025 12:00:26 +1000 (AEST) Date: Mon, 8 Sep 2025 11:53:58 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v8 5/5] test: Explicit specify forwarding ports for pasta in log rotation tests Message-ID: References: <20250905064317.213246-1-david@gibson.dropbear.id.au> <20250905064317.213246-6-david@gibson.dropbear.id.au> <20250905130340.40207517@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="U+nYgTMy4mFiAy3z" Content-Disposition: inline In-Reply-To: <20250905130340.40207517@elisabeth> Message-ID-Hash: SWYIUBMFZCKLIHUW7RXVOKUIA3MYVCPL X-Message-ID-Hash: SWYIUBMFZCKLIHUW7RXVOKUIA3MYVCPL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --U+nYgTMy4mFiAy3z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 05, 2025 at 01:03:40PM +0200, Stefano Brivio wrote: > On Fri, 5 Sep 2025 16:43:17 +1000 > David Gibson wrote: >=20 > > test/pasta_options/log_to_file uses tcp_crr in a loop to generate log > > messages for what it's actually testing. For this to work, pasta needs= to > > forward two ports. We set a PORTS variable with the options for this, = but > > never actually use it. The test works, because without the options we = use > > automatic port forwarding. >=20 > Oops. >=20 > > That makes the test more fragile than it needs to be, in a way that's n= ot > > at all related to what we're actually trying to test. Avoid this possi= ble > > point of failure by explicitly specifying the forwarding. > >=20 > > I encountered this because Fedora has now updated to a kernel with the > > /proc/net lseek() bug. >=20 > By the way, the fix is now in mainline as 2ce3d282bd50 ("proc: fix > missing pde_set_flags() for net proc files"). I hoped the breakage would > never reach distributions but I guess the timing was unlucky enough. Apparently so. Oh well, good to know the fix is upstream. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --U+nYgTMy4mFiAy3z Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmi+NzUACgkQzQJF27ox 2GcsLBAAg/lk5t0yYRPpp+7bnacgfCVEa1UT5uA1uPv20uZcOc9zBh3B8laDbDAU zA91fWqra7n3SWr+tFkZDBiBOL2LpDOzGhTrUWMijRQ7bNVFadVAyD1yM6JOQXln q8jlTwgIrjbMRcvD4dazsi4gVplWOQOoxfrE+x2F04P9bFHTACbhdkUnDeFDw1fy fnMAbBCpEKlTbnO5MkwnFHv1O1UB+WOAzNOgGCrxmwzIIaH8c9FWwRxUMd0xBheP +XJVXzA0iNTTPSi0LtRoKwF4scrpgJBV8z4qZrxkk34QaA8Y2fIvf1qHhRmgU8b9 nVRKmyqzCo5tOlupfqk7yv42Lyu1gMnkkmWTuz2YXpGMEg9jv6kpk3DVG5KYI/MH LKtNGVj8yp7lqK+3npVFl3JGaDbMTZBCriP2k30nifjizyBY03GChn0p920ldEb2 ewcd3bRgr9BLuIgD8b+neGNS3UfqN80hrP36aapvIvqBcCAmVoRtaKpSIReRpBD5 e6eIpan6dxoNgorW4CQGhUwAtkBJhrkbcqyjOQXTUGDBe3q0oIs2omCyj9G7v+Lq 0GnY7hvor7dcwjVeqYbeSGPFghU4LzNwX3dNv6LTQjAUEMndhWHyp2avfQAa4xdw y8aCnbR2mx3fhCuhEH5X9++JT7jPYU/aRo6yV8iSFfg1MmxGTDE= =l8/1 -----END PGP SIGNATURE----- --U+nYgTMy4mFiAy3z--