From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=ddx6qSr5; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 9DBA85A0271 for ; Mon, 08 Sep 2025 06:11:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1757304687; bh=g4pced3Kk6pvTmJZ9ChLKYi2a/2caDDk1s/RuOA7CM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ddx6qSr5WZl3+5jF+OEQhRHuzL0pOaJrz7WG8HJCVbanHbdXqEJofpnTepyaPZCCS X6fnDNHh5UyLmssZuUUIabNKsHAo0k511zRSz29zVLF5UxjlJjemhj3Uv7tIKIPH4u eXrzTZkR5vLJWZ5/lvKgl/0nTVx9bgkVSPmgLduGTHBGEqnXBcxf5mdA+lnlRJntaK L16dLxEXr+ShJrW0fVxMZsyWteT6KXTq9U67r1IpsJes6+CCJXL5zSL4iONhBjBe5r EXgDJgJLuNiTDl6bsOerHwxv3zHYOswiI8R9mwZP/m5ogCVbdco7hbA5vXrp9dqaFx H2vVqjmxjzuvg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cKtmv5q7Yz4w9q; Mon, 8 Sep 2025 14:11:27 +1000 (AEST) Date: Mon, 8 Sep 2025 14:04:23 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v8 5/5] test: Explicit specify forwarding ports for pasta in log rotation tests Message-ID: References: <20250905064317.213246-1-david@gibson.dropbear.id.au> <20250905064317.213246-6-david@gibson.dropbear.id.au> <20250905130340.40207517@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mBkhjD09f5uUqQ8s" Content-Disposition: inline In-Reply-To: Message-ID-Hash: LJWC2OSPDN6UEPYZESJJBMR4UPE3MALM X-Message-ID-Hash: LJWC2OSPDN6UEPYZESJJBMR4UPE3MALM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --mBkhjD09f5uUqQ8s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 08, 2025 at 11:53:58AM +1000, David Gibson wrote: > On Fri, Sep 05, 2025 at 01:03:40PM +0200, Stefano Brivio wrote: > > On Fri, 5 Sep 2025 16:43:17 +1000 > > David Gibson wrote: > >=20 > > > test/pasta_options/log_to_file uses tcp_crr in a loop to generate log > > > messages for what it's actually testing. For this to work, pasta nee= ds to > > > forward two ports. We set a PORTS variable with the options for this= , but > > > never actually use it. The test works, because without the options w= e use > > > automatic port forwarding. > >=20 > > Oops. > >=20 > > > That makes the test more fragile than it needs to be, in a way that's= not > > > at all related to what we're actually trying to test. Avoid this pos= sible > > > point of failure by explicitly specifying the forwarding. > > >=20 > > > I encountered this because Fedora has now updated to a kernel with the > > > /proc/net lseek() bug. > >=20 > > By the way, the fix is now in mainline as 2ce3d282bd50 ("proc: fix > > missing pde_set_flags() for net proc files"). I hoped the breakage would > > never reach distributions but I guess the timing was unlucky enough. >=20 > Apparently so. Oh well, good to know the fix is upstream. Hmm... Fedora is still on 6.16.4, so possibly they explicitly backported the bad patch? Oops. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --mBkhjD09f5uUqQ8s Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmi+VcYACgkQzQJF27ox 2GfS/Q/+Jr1coBKee9MbBQGXDzJuZ6IZy2PveN0VG5IiYzSj5OM2H451u36dqax1 5ckv90RFulIvIeMKUhnr+94ACv/al6WyvEwhVSxo41lLp2Y5QxcwWDI4Dj4F8dUd o9tYFy0WrI315FVNiu+OQG+A4t8+vpzc2uEL2efl+hcZVWKQjbss6CK3J3b+WNK4 q9Gp8sTCr61iZEIkXDQa2QGaCRE9Z+liK0BqFv1b50jGM2Bv6tSrp1mOiQaFhf7z bJoaLh0+mlhkpuf2cDTXyb9lj1X8i8cHQeAn/5wn3Auop9tMplVCU6KF/py/h2na oxRuk9x5LAkFp4PqB3zXqxj767HEkQR6b+H/y7s88reUqghyq7DurGL5ipzsDNya CG9clCTSXcsWz/CF7D9kmdPxjZ1vwEiA4OSmFYjYROPbiD8OddrMscdRowldfClB +DaUaqyj6CWTeztY6FHNV7OZf+9B3jRBXCE0eWiorYo5h9TVGk9Rz9Dy9b9F7uv2 SiM4C7PxbJkhLZKeywSqrVTgllDrPMBkd5tXfgF0PKCSsR4FTjkV7PW/OrUQ2Ggx L5bj4WGySfuxYfa0jALoXxxTuwuAQ1cvXC5dlrHT5xQM5Zd93jXKdLtBQ3B9ESMI xw4pJaXJpnd8OWwYI8LC27dye7hwRbJJ+11mw65D6+aCCRvKv7A= =s777 -----END PGP SIGNATURE----- --mBkhjD09f5uUqQ8s--