Re: [PATCH] test: Fix QEMU_EFI.fd not found error on non-ARM platforms

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

On Mon, Sep 08, 2025 at 10:10:17AM +0200, Stefano Brivio wrote:
> On Mon,  8 Sep 2025 15:33:09 +0800
> Yumei Huang <yuhuang@redhat.com> wrote:
> 
> > Fix the following error when running `make assets` under test on
> > non-ARM platforms:
> > 
> > ./find-arm64-firmware.sh QEMU_EFI.fd
> > Couldn't find QEMU_EFI.fd
> > make: *** [Makefile:68: QEMU_EFI.fd] Error 1
> 
> Hmm, wait, this is needed to run ARM guests, but not necessarily on
> ARM.

Right.

> The test/distro tests (currently skipped) can use QEMU TCG to run ARM
> guests on (kind of) any host architecture, and actually the only usage
> I've ever made of find-arm64-firmware.sh is on x86_64.
> 
> It still works for me there. On Fedora and related, you need to install
> the edk2-aarch64 package, and it's qemu-efi-aarch64 on Debian and
> Debian-based distributions.

The firmware package should be installed as a dependency of
qemu-system-aarch64, which is also necessary to run those ARM TCG
tests.

Since this is only used by the distro tests, we could also disable
this for the time being, with the intent to bring it back with the
rest of the distro images.  However, unlike the distro images it's
much easier and quicker to install, so there's not so much incentive.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]