Re: [PATCH v7 0/4] Introduce first exeter based test infrastructure

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]

On Fri, Sep 05, 2025 at 01:14:33AM +0200, Stefano Brivio wrote:
> On Thu,  4 Sep 2025 12:50:00 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > Here's a new approach to building passt tests with exeter.  This new
> > one no longer uses Avocado in the default case, although it would
> > still be possible to manually run the exeter based tests with Avocado.
> > 
> > For now this only does simple tests, to show how the integration could
> > work.  It adds some new trivial "smoke tests" and converts the linter
> > and build checks to exeter.  More complex tests will require building
> > the tunbridge library we've discussed.  A lot of the work for that
> > already exists in my earlier exeter test series, but it will need some
> > rework to split it into a separate component.
> > 
> > v7:
> >  * Use "exetool list" rather than "--list" directly to get test manifest.
> >  * Update Makefiles to automatically update exeter sources as necessary.
> >  * Update series cover letter removing some outdated information.
> 
> I was about to apply this, but then realised that the usual build test
> links at https://passt.top/#ci disappeared, see also
> https://passt.top/builds/latest/web/ci.js.

Huh, that's weird.

> I didn't really investigate
> yet, we're missing something equivalent to the "test" directive.

We shouldn't be.  exeter() calls status_test_{start,ok,fail} much like
test().

> If I
> recall correctly, that was working in v5, but I'm not sure why. I still
> need to look into this, unless you figure it out meanwhile.

Right, you said v5 worked.  Hrm.... one of the main differences since
v5 is getting the descriptions, which *are* used as the parameter to
status_test_start.  Could the descriptions be using some character we
weren't before and we're missing an escape somewhere?  Not seeing an
obvious spot.

> Something minor I noticed is that indentation of some lines in
> run_selected() is broken now (spaces instead of tabs).

Drat, I thought I fixed my editor config for that.  I've fixed it in
my branch, I'll hold of on another spin until we figure out what's
going on with the CI links.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]