From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=PIUwruKD; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 38AAA5A027C for ; Fri, 05 Sep 2025 08:43:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1757054599; bh=Eud0ORhthT9l9MZKOoE8uZ5VLAMHvdBZm+t+bG6hRXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PIUwruKDPLNndLWPitBNgahQzmPsYaYBjprxIjw8ikkhA6PVYaXGcZYL2PQlTgCFK uOmnkcsHoUj59w13/er3uVYQ7oh39E9i5T9egXUJ/H+IV2aNG+kMlls8of9mh8iv5y +CpqsitCe8T40f96rd76UDRI7PHwUqXk50QcDuclIc2R0AFmHK3nePjMgj6jPaOC1J JpBeOObBwhsOWdzZUS1HUyXf5ebCzCl9y5FOFhsWv6TjNLdWTPUAKldPDfBCHhcaC0 HXae2p1FIz+3Ug2otz4Ae7CBazEY0oTasVPF6lfWQ02F1REhJbE03Ab944LqLM79hG u9fMZ2XUhB9/w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cJ6HW4jn2z4w9c; Fri, 5 Sep 2025 16:43:19 +1000 (AEST) Date: Fri, 5 Sep 2025 16:42:58 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v7 0/4] Introduce first exeter based test infrastructure Message-ID: References: <20250904025004.491185-1-david@gibson.dropbear.id.au> <20250905011433.41c0d242@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iHKcDsbsg8IPYM0m" Content-Disposition: inline In-Reply-To: Message-ID-Hash: FG7ZRYITR2KF6HMWZU2RS3FNLFY4AOOS X-Message-ID-Hash: FG7ZRYITR2KF6HMWZU2RS3FNLFY4AOOS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --iHKcDsbsg8IPYM0m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 05, 2025 at 11:35:53AM +1000, David Gibson wrote: > On Fri, Sep 05, 2025 at 01:14:33AM +0200, Stefano Brivio wrote: > > On Thu, 4 Sep 2025 12:50:00 +1000 > > David Gibson wrote: > >=20 > > > Here's a new approach to building passt tests with exeter. This new > > > one no longer uses Avocado in the default case, although it would > > > still be possible to manually run the exeter based tests with Avocado. > > >=20 > > > For now this only does simple tests, to show how the integration could > > > work. It adds some new trivial "smoke tests" and converts the linter > > > and build checks to exeter. More complex tests will require building > > > the tunbridge library we've discussed. A lot of the work for that > > > already exists in my earlier exeter test series, but it will need some > > > rework to split it into a separate component. > > >=20 > > > v7: > > > * Use "exetool list" rather than "--list" directly to get test manif= est. > > > * Update Makefiles to automatically update exeter sources as necessa= ry. > > > * Update series cover letter removing some outdated information. > >=20 > > I was about to apply this, but then realised that the usual build test > > links at https://passt.top/#ci disappeared, see also > > https://passt.top/builds/latest/web/ci.js. >=20 > Huh, that's weird. >=20 > > I didn't really investigate > > yet, we're missing something equivalent to the "test" directive. >=20 > We shouldn't be. exeter() calls status_test_{start,ok,fail} much like > test(). Ah.. but I didn't call video_link, like test_one() did. Which explains why the new tests weren't getting links... but not why it broke the existing ones. Well, I've put that in, and ci.js looks sane to me, but I don't really know how that video stuff works. I'll send v8. > > If I > > recall correctly, that was working in v5, but I'm not sure why. I still > > need to look into this, unless you figure it out meanwhile. >=20 > Right, you said v5 worked. Hrm.... one of the main differences since > v5 is getting the descriptions, which *are* used as the parameter to > status_test_start. Could the descriptions be using some character we > weren't before and we're missing an escape somewhere? Not seeing an > obvious spot. >=20 > > Something minor I noticed is that indentation of some lines in > > run_selected() is broken now (spaces instead of tabs). >=20 > Drat, I thought I fixed my editor config for that. I've fixed it in > my branch, I'll hold of on another spin until we figure out what's > going on with the CI links. >=20 > --=20 > David Gibson (he or they) | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you, not the other way > | around. > http://www.ozlabs.org/~dgibson --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --iHKcDsbsg8IPYM0m Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmi6hmIACgkQzQJF27ox 2GddTRAAp0qwT2ypq81ihU/lhPSG8Cbm12Esd+i8BgdzI2YVCObL1kbFfm4KGaXq 481uFhzgwv+dxWbrh23u9OF0Sfgz2zBZc9hl22y4eZfzMAOQUmInNuCoB8yVRB3/ RT9Nu5obRzcDk9FAiMO2oFFvE04N27oLWAyeaW/X7O+Vpa/dB9AH/5AED1t6hx8M YAofTqcdw2TocMPJ9lgLQaciyRTV20RMu5r3TyGo5//r5WN6hU3eZTjNvz2+5SJf Zf9Z99I08FuAJ0fM2q/TIZSwv3QvGkgw6tvgvT1vtH+eWt/iYWbi1ZBazlQf3+JV kufcvdkQCStEmH5ySIco+P+D+c7SwF/DOM2H699zZQr7l3XCtKMxW/LeiLI+itIx 6YSTcFKVsOo99tVU1ymsJ6wAVV30nLUaGGU87sFdijhoNjM+Fnm7KKFYl2feYXDj 7LqQ70my6XnW/KIiCCAvKfgo8borocKq47MCVGgxxrd2hvBEgfbcUYLoKygqmA3t WJhsTG+bkgRiqkEFlmbUoTogYdz6JjiiU7Khic+CR9tfJWgn8n86gasBKxnaar/s MN8QHl6gvEczP4reB9FUa/yPZwbGxnSR02XHzmRR63mLWqhh0G713pNb4GNQjOQd epnXTLo+asZLz0hssSBjPvk2RZxqxhEVKRrTzOZfJQNW8mN2yV4= =WDGz -----END PGP SIGNATURE----- --iHKcDsbsg8IPYM0m--