Re: [PATCH v5 4/5] Fix --no-icmp description and make it imply --no-ndp

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

On Thu, Sep 11, 2025 at 10:19:03PM +0200, Volker Diels-Grabsch wrote:
> Signed-off-by: Volker Diels-Grabsch <v@njh.eu>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  conf.c  | 3 +++
>  passt.1 | 4 ++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/conf.c b/conf.c
> index f47f48e..02e903b 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -2067,6 +2067,9 @@ void conf(struct ctx *c, int argc, char **argv)
>  
>  	isolate_user(uid, gid, !netns_only, userns, c->mode);
>  
> +	if (c->no_icmp)
> +		c->no_ndp = 1;
> +
>  	if (c->pasta_conf_ns)
>  		c->no_ra = 1;
>  
> diff --git a/passt.1 b/passt.1
> index cef98b2..dd00b08 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -319,8 +319,8 @@ silently dropped.
>  
>  .TP
>  .BR \-\-no-icmp
> -Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests coming from
> -guest or target namespace will be silently dropped.
> +Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests coming from
> +guest or target namespace will be silently dropped. Implies \fB--no-ndp\fR.
>  
>  .TP
>  .BR \-\-no-dhcp
> -- 
> 2.47.3
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]