From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=ms4p9S7y; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E2B985A0278 for ; Fri, 12 Sep 2025 04:01:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1757642502; bh=Ev8ciWnJQuj0stSWfMWIAoIflpK1yxSxexM1gTV+qA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ms4p9S7yi6CdUoL4uyEo7A7yC5Q/n1TFHqenxm9eCM8tZSLdjEKI6A0LYu5DJXEIm eUKWtUVrPkB59osbuvyV8Hx1BpTUaes2kkwyEmA5RUs3OmFNIUANH4hQ2037W1lsy/ ZhzUxLqHfDcWWb9BXupRH6ShvdxMFULf3cQidiWQRTdCBCX4HD/mYuXnwIM1vhYm7Q Vgv/L3vl4TWQkeGEGP0rGlZ/IYCUOaLl+PZgwtyrWL3Yxhia3A/YCdls1x8BezorlD 0ARIXZlXVtveM1OyxRa8QsBLZ2/YeO3Jcbo5foPxaeRahOCM+oOCd7BnzfU5emqN3h Qrh/dOI0ga15g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cNHjL4T1Rz4wC4; Fri, 12 Sep 2025 12:01:42 +1000 (AEST) Date: Fri, 12 Sep 2025 11:18:17 +1000 From: David Gibson To: Volker Diels-Grabsch Subject: Re: [PATCH v5 4/5] Fix --no-icmp description and make it imply --no-ndp Message-ID: References: <20250911201900.237677-2-v@njh.eu> <20250911201900.237677-8-v@njh.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BqLDjsBviXqi0q7m" Content-Disposition: inline In-Reply-To: <20250911201900.237677-8-v@njh.eu> Message-ID-Hash: EUBDTSFW6OECC6I5BW5OTJ3GHCU2LDME X-Message-ID-Hash: EUBDTSFW6OECC6I5BW5OTJ3GHCU2LDME X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --BqLDjsBviXqi0q7m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 11, 2025 at 10:19:03PM +0200, Volker Diels-Grabsch wrote: > Signed-off-by: Volker Diels-Grabsch Reviewed-by: David Gibson > --- > conf.c | 3 +++ > passt.1 | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index f47f48e..02e903b 100644 > --- a/conf.c > +++ b/conf.c > @@ -2067,6 +2067,9 @@ void conf(struct ctx *c, int argc, char **argv) > =20 > isolate_user(uid, gid, !netns_only, userns, c->mode); > =20 > + if (c->no_icmp) > + c->no_ndp =3D 1; > + > if (c->pasta_conf_ns) > c->no_ra =3D 1; > =20 > diff --git a/passt.1 b/passt.1 > index cef98b2..dd00b08 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -319,8 +319,8 @@ silently dropped. > =20 > .TP > .BR \-\-no-icmp > -Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests comi= ng from > -guest or target namespace will be silently dropped. > +Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests comin= g from > +guest or target namespace will be silently dropped. Implies \fB--no-ndp\= fR. > =20 > .TP > .BR \-\-no-dhcp > --=20 > 2.47.3 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --BqLDjsBviXqi0q7m Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjDdNgACgkQzQJF27ox 2GcC0w/+KeAz4iXVVHrfJn8A7WcJuKYNmv5jC8mWKe7MeOcqhCdA/NjN9KKGCh5b K1kC7IvvgTT8tgSIjP1za3AVK8PvHtozVsiEkofzLJc9CJp5vzFZvSxos+fDvUiX D3MpVLKpRwXD9OULbk7N2sXQu9ywr6RRrfsZy1aGSlLszBv8il4CpDEfDuucEfjt NPlNEVQfsmGNx7LqiHU7kZ4rcRP+uTeBErfBBVadsRnq5i7FI4B5UJD8qOe2McjT R26MBvZmqdqTJP+hpOtIW1+smkr0nL6261E7RUQgozY395gbknUZo3NfwqvT3Qu/ aO+yLtOsWOF5nKDo0FqCbBU1PR3J1pXUmqIvZfThVybsbUqEDPMcYMbMoHomNrwN 2T+Fk1kSZzc7JcU1rXX9H5ZPstnm8LjPDQTKCL0gD9mOf51BObJp/Zn2iLP6dP2C 4KdWysgcos1kphXWLxg4ghocC77osX96A8NYq0mSilNjZySp/x76C6RXJEL5crlf J/lkFHOI4dxXsphE/o2AUAwrVXDwKozP096AhOQB13zaBiastYu4HWQVOME/9fM2 ninBozcWF9Z1G7odfpJKblutGwxizdbS7UAiEO2KPobmz/bWX8sXMemVguURfNwP c5v2ZL5GJCv+zEA8LTyGZ1cC50OZI/hrYo5S1F9O4K/KiKGzkVk= =e17I -----END PGP SIGNATURE----- --BqLDjsBviXqi0q7m--