From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=ry1+MZnf; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 2BFBD5A027A for ; Fri, 12 Sep 2025 04:01:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1757642502; bh=d0t6T6oQosIW/sHYsHeg/4iBi0PejMJQRFXRbtl/7ds=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ry1+MZnfldgxQ7Ka+UWRXEIpLfykLd1UIwhEoZh2hUSe84lHXhLAsA40For+grDvt kxj4P7i1weESH/32hDmu7OueOFqvqQ6yhyoIStpK05v5povhSjmnHUde+EhdwbXLA/ BQ3AFwampIM8/2I/FWbYs5Hep1b35x/lZjhifFC2m0Z2r1nf+/oay1sWsc01tGK++C BwuthZ6fyJFULQ6BpqGcZ4cBtKJ/UHElycR5EVNy0VcsGp9abE7pAfI5aVacqRueMx jn0B1SD+q16Y3tdFxlF1s8uE6dYrvr79ipOiQdAvvtLZJNWpr6gYcPnNh8lKul4dNj ZPZ0rQaY9OSMw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cNHjL3wNKz4w9h; Fri, 12 Sep 2025 12:01:42 +1000 (AEST) Date: Fri, 12 Sep 2025 11:17:16 +1000 From: David Gibson To: Volker Diels-Grabsch Subject: Re: [PATCH v5 2/5] Improve clarity of comment Message-ID: References: <20250911201900.237677-2-v@njh.eu> <20250911201900.237677-4-v@njh.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="utTM/HWnK9wDLeY3" Content-Disposition: inline In-Reply-To: <20250911201900.237677-4-v@njh.eu> Message-ID-Hash: LLC2EWJWSEPTADXLCMEEIXZHPGXGDLTI X-Message-ID-Hash: LLC2EWJWSEPTADXLCMEEIXZHPGXGDLTI X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --utTM/HWnK9wDLeY3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 11, 2025 at 10:18:59PM +0200, Volker Diels-Grabsch wrote: > Signed-off-by: Volker Diels-Grabsch Commit message should probably say specifically what was inaccurate / misleading about the original version. Btw, for some reason I didn't receive 1/5 in this series. > --- > tap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/tap.c b/tap.c > index 3c08126..d4d19eb 100644 > --- a/tap.c > +++ b/tap.c > @@ -1507,9 +1507,9 @@ void tap_backend_init(struct ctx *c) > case MODE_PASST: > tap_sock_unix_init(c); > =20 > - /* In passt mode, we don't know the guest's MAC address until it > - * sends us packets. Use the broadcast address so that our > - * first packets will reach it. > + /* In passt mode, we don't know the guest's MAC address until > + * it sends us packets. Until then, use the broadcast address > + * so that our first packets will have a chance to reach it. > */ > memset(&c->guest_mac, 0xff, sizeof(c->guest_mac)); > break; > --=20 > 2.47.3 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --utTM/HWnK9wDLeY3 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjDdIwACgkQzQJF27ox 2GcZ0RAAgkYpv3vmdSlu+o0G2rbX47h0cJTnKBbaD2Z4HI3pEqdSWayLATHfSL9p gGuO8X3SWr7iSJkE8HkWISJIUKCAEIsLsIoH8yF2Z8fyQ5w4U1+sdD2NZA2CjyAE 1cO7KLEgXsQcrECR3avQBY1fM8451OuOUarBliV6W9CVf56i9XwR0rjeigQBUR33 jt5v6ODi/VnfoB7ykecFBfRVBMjHfIgZGvp9THqQmTsk/hVJA0HxN/c56TAVYpW3 hcTNQTf+UZ+eWzLyRN/PTZVzYBmGQm8EkBWgoiaTj8OMvirzqrlUw/ChBYTH1/77 3jPyDKHbAeVaqN21NxebyL0yKmVejx8vJ/TQK707qrMUCfSLPI3Ay6JApC+uwWzr NvlrzpjUjj2/7/fchR603aJPLDahZKQsjeJaTO9ig1Ke0JcqoFq9IM92ksXIoG3u gG9w9kIboGd129kyzSawoxgRZMJp1RC/q46sBCbY43t8Hm2QJNolBv0RbFa/8aUI CwECW74jM1jYQ9KpQSqcIdFXC1shci4EdBkmiIbGD5T/3tzC0k1lT4QeM3aIWE48 DE13tbZJnmRRaEuDQwxRW9ekVGmXswUpDEqTHIIGf7MIxCoNrwMgCP+IRJr6sRxp 8KuB8y6x0WNF8F4gavcFFVJjkRaVkhkw1KkuF8tn0mG/DEace54= =O7Ya -----END PGP SIGNATURE----- --utTM/HWnK9wDLeY3--