public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Volker Diels-Grabsch <v@njh.eu>, passt-dev@passt.top
Subject: Re: [PATCH v5 2/5] Improve clarity of comment
Date: Fri, 12 Sep 2025 17:38:46 +1000	[thread overview]
Message-ID: <aMPOBm2RdQFEwboC@zatzit> (raw)
In-Reply-To: <20250912083513.2d751f86@elisabeth>

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

On Fri, Sep 12, 2025 at 08:35:13AM +0200, Stefano Brivio wrote:
> On Fri, 12 Sep 2025 11:17:16 +1000
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > On Thu, Sep 11, 2025 at 10:18:59PM +0200, Volker Diels-Grabsch wrote:
> > > Signed-off-by: Volker Diels-Grabsch <v@njh.eu>  
> > 
> > Commit message should probably say specifically what was inaccurate /
> > misleading about the original version.
> > 
> > Btw, for some reason I didn't receive 1/5 in this series.
> 
> Your email relay accepted it at 20:19:35.98982 UTC:
> 
> 2025-09-11T22:19:35.989820+02:00 ... : *****: to=<david@gibson.dropbear.id.au>, relay=mx.ozlabs.org[********]:25, delay=8.2, delays=0.05/0.01/3.6/4.5, dsn=2.0.0, status=sent (250 2.0.0 Ok: queued as *****)
> 
> If needed:
> 
>   https://archives.passt.top/passt-dev/20250911201900.237677-2-v@njh.eu/raw

Huh.  Looked back through my received archive and there it was.  Which
implies I somehow deleted it from my inbox without noticing.  Oops.

> ...maybe you confused it with a cover letter that's missing in this
> case? By the way, I don't see an issue with that if it's mostly a bunch
> of trivial changes.

Maybe, but I don't generally delete cover letters unseen.

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-09-12  7:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 20:18 [PATCH v5 1/5] Show debug message whenever we learn a new guest MAC address Volker Diels-Grabsch
2025-09-11 20:18 ` [PATCH v5 2/5] Improve clarity of comment Volker Diels-Grabsch
2025-09-12  1:17   ` David Gibson
2025-09-12  6:35     ` Stefano Brivio
2025-09-12  7:38       ` David Gibson [this message]
2025-09-11 20:19 ` [PATCH v5 3/5] Introduce constant MAC_BROADCAST Volker Diels-Grabsch
2025-09-12  1:17   ` David Gibson
2025-09-11 20:19 ` [PATCH v5 4/5] Fix --no-icmp description and make it imply --no-ndp Volker Diels-Grabsch
2025-09-12  1:18   ` David Gibson
2025-09-11 20:19 ` [PATCH v5 5/5] Send an initial ARP and NDP request to resolve the guest IP address Volker Diels-Grabsch
2025-09-12  3:29   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMPOBm2RdQFEwboC@zatzit \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    --cc=v@njh.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).