public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Volker Diels-Grabsch <v@njh.eu>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v5 1/5] Show debug message whenever we learn a new guest MAC address
Date: Tue, 16 Sep 2025 21:04:08 +0200	[thread overview]
Message-ID: <aMm0qNApzZKAQp18@6153f789-1cf1-4ca3-8cea-6fa7ae195a8b.njh.eu> (raw)
In-Reply-To: <20250913121545.1d19ca10@elisabeth>

Stefano Brivio wrote:
> Volker Diels-Grabsch <v@njh.eu> wrote:
> > +		debug("Guest MAC address: %s",
> 
> I think this should say "New guest MAC address", or maybe even "New
> guest MAC address observed" (a bit verbose though).
> 
> Otherwise it's not really clear to users what we're referring to here.

I actually prefer the more verbose version.


Regards,
Volker

-- 
.---<<<((()))>>>---.
|      [[||]]      |
'---<<<((()))>>>---'

      reply	other threads:[~2025-09-16 19:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 20:18 Volker Diels-Grabsch
2025-09-11 20:18 ` [PATCH v5 2/5] Improve clarity of comment Volker Diels-Grabsch
2025-09-12  1:17   ` David Gibson
2025-09-12  6:35     ` Stefano Brivio
2025-09-12  7:38       ` David Gibson
2025-09-11 20:19 ` [PATCH v5 3/5] Introduce constant MAC_BROADCAST Volker Diels-Grabsch
2025-09-12  1:17   ` David Gibson
2025-09-11 20:19 ` [PATCH v5 4/5] Fix --no-icmp description and make it imply --no-ndp Volker Diels-Grabsch
2025-09-12  1:18   ` David Gibson
2025-09-11 20:19 ` [PATCH v5 5/5] Send an initial ARP and NDP request to resolve the guest IP address Volker Diels-Grabsch
2025-09-12  3:29   ` David Gibson
2025-09-13 10:15 ` [PATCH v5 1/5] Show debug message whenever we learn a new guest MAC address Stefano Brivio
2025-09-16 19:04   ` Volker Diels-Grabsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMm0qNApzZKAQp18@6153f789-1cf1-4ca3-8cea-6fa7ae195a8b.njh.eu \
    --to=v@njh.eu \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).