From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=njh.eu
Received: from mail.notjusthosting.com (mail.notjusthosting.com [IPv6:2a01:4f8:a0:516f:1::1])
	by passt.top (Postfix) with ESMTPS id 77D605A068E
	for <passt-dev@passt.top>; Tue, 16 Sep 2025 21:04:10 +0200 (CEST)
Received: from [2a01:599:10d:cf12:83c1:fa7e:d576:60f] (helo=vlap)
	by mail.notjusthosting.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <v@njh.eu>)
	id 1uyayH-0001ZI-V7; Tue, 16 Sep 2025 21:04:10 +0200
Date: Tue, 16 Sep 2025 21:04:08 +0200
From: Volker Diels-Grabsch <v@njh.eu>
To: Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH v5 1/5] Show debug message whenever we learn a new guest
 MAC address
Message-ID: <aMm0qNApzZKAQp18@6153f789-1cf1-4ca3-8cea-6fa7ae195a8b.njh.eu>
References: <20250911201900.237677-2-v@njh.eu>
 <20250913121545.1d19ca10@elisabeth>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250913121545.1d19ca10@elisabeth>
Message-ID-Hash: OXFORC6QBNORNLFUR3NRDXYIKAM66JD3
X-Message-ID-Hash: OXFORC6QBNORNLFUR3NRDXYIKAM66JD3
X-MailFrom: v@njh.eu
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: passt-dev@passt.top
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/aMm0qNApzZKAQp18@6153f789-1cf1-4ca3-8cea-6fa7ae195a8b.njh.eu/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/OXFORC6QBNORNLFUR3NRDXYIKAM66JD3/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

Stefano Brivio wrote:
> Volker Diels-Grabsch <v@njh.eu> wrote:
> > +		debug("Guest MAC address: %s",
> 
> I think this should say "New guest MAC address", or maybe even "New
> guest MAC address observed" (a bit verbose though).
> 
> Otherwise it's not really clear to users what we're referring to here.

I actually prefer the more verbose version.


Regards,
Volker

-- 
.---<<<((()))>>>---.
|      [[||]]      |
'---<<<((()))>>>---'