From: David Gibson <david@gibson.dropbear.id.au>
To: Volker Diels-Grabsch <v@njh.eu>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 1/5] Show debug message whenever we observe a new guest MAC address
Date: Wed, 17 Sep 2025 15:05:24 +1000 [thread overview]
Message-ID: <aMpBlKXhhMvYq3b-@zatzit> (raw)
In-Reply-To: <20250916192209.3986375-2-v@njh.eu>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On Tue, Sep 16, 2025 at 09:21:12PM +0200, Volker Diels-Grabsch wrote:
> Signed-off-by: Volker Diels-Grabsch <v@njh.eu>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> tap.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tap.c b/tap.c
> index 7ba6399..cf862ef 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -1096,7 +1096,11 @@ void tap_add_packet(struct ctx *c, struct iov_tail *data,
> return;
>
> if (memcmp(c->guest_mac, eh->h_source, ETH_ALEN)) {
> + char bufmac[ETH_ADDRSTRLEN];
> +
> memcpy(c->guest_mac, eh->h_source, ETH_ALEN);
> + debug("New guest MAC address observed: %s",
> + eth_ntop(c->guest_mac, bufmac, sizeof(bufmac)));
> proto_update_l2_buf(c->guest_mac, NULL);
> }
>
> --
> 2.47.3
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-09-17 7:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 19:21 [PATCH v6 1/5] Volker Diels-Grabsch
2025-09-16 19:21 ` [PATCH 1/5] Show debug message whenever we observe a new guest MAC address Volker Diels-Grabsch
2025-09-17 5:05 ` David Gibson [this message]
2025-09-16 19:21 ` [PATCH 2/5] Introduce constant MAC_BROADCAST Volker Diels-Grabsch
2025-09-17 7:29 ` David Gibson
2025-09-16 19:21 ` [PATCH 3/5] Fix --no-icmp description and make it imply --no-ndp Volker Diels-Grabsch
2025-09-17 7:29 ` David Gibson
2025-09-16 19:21 ` [PATCH 4/5] Send an initial ARP and NDP request to resolve the guest IP address Volker Diels-Grabsch
2025-09-18 2:32 ` David Gibson
2025-09-16 19:21 ` [PATCH 5/5] Improve clarity of comment Volker Diels-Grabsch
2025-09-18 2:43 ` David Gibson
2025-09-17 14:32 ` [PATCH v6 1/5] Stefano Brivio
2025-09-19 0:59 ` Volker Diels-Grabsch
2025-09-19 1:45 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMpBlKXhhMvYq3b-@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=v@njh.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).