From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=SXKGnhVb; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 4216C5A0271 for ; Wed, 17 Sep 2025 09:27:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758094070; bh=DUFqHG2v7pQmZcO2mG7LrxaZKsfXJVZIo2/c8TEAIuk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SXKGnhVbkrUfW1jbfsHBa5xzCJKgilgIIAq0c3Z2gxUEoxeDu+pBBdfnk4Nxxbi+d v+sgxZcid9bNnAbJCbiKVFAJeg7LA19xNkPK5dOpUmVc+sbXkLbYmEgTwfraOhMjCp Cx1ZE4GRWG3/qOan5+k+Ne3/JVFrQ8PYnEodTX2SY9OtclN95UD0BPboUCBiFzONA/ uIsRjxEiQPmjNtlzx8dnbODAKbZUc96637Cuge9LyGeb6zE7EGPrc0g6+HsRRZwxrZ YF7aGGjrMvdEZ0mE/j6mdta3TZoLRMz2o/6wPa0kF2QXtQXsdo8DAW6UGTXGKLpU2T sWkhyZf67aM+Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cRVjL3JBbz4wD0; Wed, 17 Sep 2025 17:27:50 +1000 (AEST) Date: Wed, 17 Sep 2025 15:05:24 +1000 From: David Gibson To: Volker Diels-Grabsch Subject: Re: [PATCH 1/5] Show debug message whenever we observe a new guest MAC address Message-ID: References: <20250916192209.3986375-1-v@njh.eu> <20250916192209.3986375-2-v@njh.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4JMDdGA/JrevSE5d" Content-Disposition: inline In-Reply-To: <20250916192209.3986375-2-v@njh.eu> Message-ID-Hash: IY2AURPXGKANGLF2WDRAAI7NKL3VCYII X-Message-ID-Hash: IY2AURPXGKANGLF2WDRAAI7NKL3VCYII X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --4JMDdGA/JrevSE5d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 16, 2025 at 09:21:12PM +0200, Volker Diels-Grabsch wrote: > Signed-off-by: Volker Diels-Grabsch Reviewed-by: David Gibson > --- > tap.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/tap.c b/tap.c > index 7ba6399..cf862ef 100644 > --- a/tap.c > +++ b/tap.c > @@ -1096,7 +1096,11 @@ void tap_add_packet(struct ctx *c, struct iov_tail= *data, > return; > =20 > if (memcmp(c->guest_mac, eh->h_source, ETH_ALEN)) { > + char bufmac[ETH_ADDRSTRLEN]; > + > memcpy(c->guest_mac, eh->h_source, ETH_ALEN); > + debug("New guest MAC address observed: %s", > + eth_ntop(c->guest_mac, bufmac, sizeof(bufmac))); > proto_update_l2_buf(c->guest_mac, NULL); > } > =20 > --=20 > 2.47.3 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --4JMDdGA/JrevSE5d Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjKQZMACgkQzQJF27ox 2GeMeA/9ELTYVvqhVdCrpsaeUeLoH8B4bYK1VcEz+VjV88FaJrZQpPk1qEaXNS2E 429SGgQZNW/Sv0Aaf7P8BkW+Y2bgC/CFG5m1p0Wf0S9L3w2KVVXSd8/KrJT2ujm4 LfScoTpnY19x/6FxOdDdDPWeMBjDnEInMBSGO1LFSmHnhyvskmzQPf79/ux3jeNJ 8YZaocKw4rlQdmKyH8u6pOJXa0Kc70jVLIFBPLietxBxJYZsufjLiqeOkKxT9Du4 ttBAxvnI428ae8BXx2NhvyfpXnJjj7RRgH6Go+V6a2fsF7SnLhKvjH1YGLGpg2BX ipTRiHZ6yrcul+TPX129SLbt5cxVSMaZuO1A2Y+k94rShpbBcRXISgfu7RpLBXJU RC9os1m+rQInXBPFSCG7DRjRSdLq/z1yiht5CaqSjTvtVhQaVTC0YawgYkp21iVJ y7WKUj7ahDCfiGd84/5tPxV3/wamsDXP72mjfgg4F65c6O2IKtn4mgqsqD1U0V9F J7ob/SPdo2XLrrXK9gCkd1VhveFIn9WZyOjO3KYtwvYQN1Rzn43UI/wohrYR1QAw S1DL4TIT0ZetDQyAsrJVDAPDlrYQlDEfrwqjoNAtDPAo+Z3uUAZd7HkMKfTjWWiy laX70ykg1DB/14YFBRnSzywVv5Tsj0Hf37BTgtM7S1F+bgo76xw= =DZE6 -----END PGP SIGNATURE----- --4JMDdGA/JrevSE5d--