From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=E+/DuvnR; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 07E945A0271 for ; Wed, 17 Sep 2025 09:28:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758094115; bh=732yu6E11celZFIhtInGYYKgowH3uM9J5D4Mly6uc2I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E+/DuvnREiJ0R6yzyvmq9V7C5q2czXq3LWg/NTI5My+W2QRtByFNSEIHMceRg3Dwv 5I9aw89Dmp7f3Lx62agUMN+bOglk+P46mlc+yWlv0dFi/TzV8XIvGnxL/p7eVE3kXD vmQvLpyc3mYfu2maiDyfeIdS3XQC8JeKZycpuHXDx+3PFjuYkpTe0AQk8v0kE1yJnq PocqSrggdkGglLzBSCIfRJYiH0pGJes9f75+EyM9wBHdXjIGj8p4B9ghh5guZAs4/w uvWFxNcG6/L43EL0k7Nb/hnhaf/PFHsdXaaGslr7zLe9qUGJYeXuQy/VYuhed79LGp Ae7gV3GRLxNFg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cRVkC0c39z4wD0; Wed, 17 Sep 2025 17:28:35 +1000 (AEST) Date: Wed, 17 Sep 2025 17:28:30 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH] dhcp: Fix coding style violations in dhcp() function Message-ID: References: <20250917064142.3854816-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bk3660CDADxe2w8O" Content-Disposition: inline In-Reply-To: <20250917064142.3854816-1-lvivier@redhat.com> Message-ID-Hash: CNXSZZFNQII6KM6V3W576PFVY3HJS2OX X-Message-ID-Hash: CNXSZZFNQII6KM6V3W576PFVY3HJS2OX X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Bk3660CDADxe2w8O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 17, 2025 at 08:41:42AM +0200, Laurent Vivier wrote: > The dhcp() function wasn't following the inverted Christmas tree > variable declaration ordering convention. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > dhcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/dhcp.c b/dhcp.c > index 012cec6c0d04..6b9c2e3b9e5a 100644 > --- a/dhcp.c > +++ b/dhcp.c > @@ -311,10 +311,10 @@ int dhcp(const struct ctx *c, struct iov_tail *data) > const struct ethhdr *eh; > const struct iphdr *iph; > const struct udphdr *uh; > + struct msg m_storage; > struct msg const *m; > struct msg reply; > unsigned int i; > - struct msg m_storage; > =20 > eh =3D IOV_REMOVE_HEADER(data, eh_storage); > iph =3D IOV_PEEK_HEADER(data, iph_storage); > --=20 > 2.50.1 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Bk3660CDADxe2w8O Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjKYx0ACgkQzQJF27ox 2GdY9g//arNdY0DrkRU52yRneIWlByEeLYgH8yZEnTYQG2ge+sStOAfgB7caWTia H6S9h62hgRQCUrUHRW2AnveYUwGxNXOozirIBg9c4/JVP4+u8mpRd+hpFpeLcZUr 1woXofk6okbsf/fOtaS/yfQ9VsV/qgXeAwThRix92w7JXRGos1dCoJd/mDBw7d1/ vG6yJzeti7p1msfxJDP7AXkNQh/yqJz6vWWGi4MoAXXUgChxS0zDyvG//PHmXXHe o8/f7+ukUwWZVO3exDPexpLJ12Nj1msavs5uUqjFLEyd+5RzfxFKlps/YzLD90JG FH+g8HINtYSRbI5kBDSBx87lGwNVX71BZAQrGNKOYkofxGDpyhcGOKWUCydzGJSq +qZza5YZB3UEDJPCpqks9TjfS91U508Cjy58pCNhrDVuvs5Qg9KvN22wV/hBFl+o 3v4epkrXI9BzrjennAG3U5pDO/O630L/uQyHRl2p+19k0JPd6EWaiW7ijMGZQEGd 5+QdfWw98Mw7htCbNVhhDiAB2cHBV8sgBNH/XSGdB9wS3IZEa56xChNd8x9HKNHk rRGEC2jpQjZqF8Kb60J3qvPA29zIvOyyw6/4aZbxJw99fBryAhDVirWd4/+fryHo dHBWH4a5z7jRF094zmK/gzw3QumvTYG+d5gLzV9ANA8v4L5mBFY= =Weyb -----END PGP SIGNATURE----- --Bk3660CDADxe2w8O--