From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=DnwzHivn; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 80D535A0271 for ; Wed, 17 Sep 2025 09:30:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758094201; bh=FvDMk+G9JQWfQV0V1OIt0UOUShXgBmpxUNtsXmDX/Xo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DnwzHivnMB7It/rc2fjwdFPqb3CDMeDi8nzNiVHRX3oQOQN+V+MSkdsKmEtIvQvGa W8SPLfFMe10CbHHFKZTwCt14f5Lf3fKGOSdjUtemq5gkNJYsN+no7Jr+Fj9fCEFLTh tbPO5EMwiW3CXNXvS8FpGmMLWrThUzMQ3u4ryKF4Gyomtf4vHcnblTi3ToaUKttQWV ux8IVbhbw1p4JEmYXFZwA5hbTKXlnMgDbfdNVr5J4gn9DDphkLEj+yXOFoygaxwOaD CwW+EeV6cWCoUZFGECTpzpQGYl/fP+IVJnAjGvxNisNfg8ZCv6jFaWbgphyVRmKiMV gSFDpgUA1feNA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cRVls4fTLz4wD3; Wed, 17 Sep 2025 17:30:01 +1000 (AEST) Date: Wed, 17 Sep 2025 17:29:14 +1000 From: David Gibson To: Volker Diels-Grabsch Subject: Re: [PATCH 2/5] Introduce constant MAC_BROADCAST Message-ID: References: <20250916192209.3986375-1-v@njh.eu> <20250916192209.3986375-3-v@njh.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y0HKT7lhPDsksxY6" Content-Disposition: inline In-Reply-To: <20250916192209.3986375-3-v@njh.eu> Message-ID-Hash: 4EJCJFYXTUN75P66AMMEDGYAY22SO4QJ X-Message-ID-Hash: 4EJCJFYXTUN75P66AMMEDGYAY22SO4QJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --y0HKT7lhPDsksxY6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 16, 2025 at 09:21:13PM +0200, Volker Diels-Grabsch wrote: > Signed-off-by: Volker Diels-Grabsch Reviewed-by: David Gibson > --- > tap.c | 2 +- > util.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/tap.c b/tap.c > index cf862ef..50e1a88 100644 > --- a/tap.c > +++ b/tap.c > @@ -1511,7 +1511,7 @@ void tap_backend_init(struct ctx *c) > * sends us packets. Use the broadcast address so that our > * first packets will reach it. > */ > - memset(&c->guest_mac, 0xff, sizeof(c->guest_mac)); > + memcpy(&c->guest_mac, MAC_BROADCAST, sizeof(c->guest_mac)); > break; > } > =20 > diff --git a/util.h b/util.h > index 2a8c38f..22eaac5 100644 > --- a/util.h > +++ b/util.h > @@ -97,6 +97,8 @@ void abort_with_msg(const char *fmt, ...) > #define FD_PROTO(x, proto) \ > (IN_INTERVAL(c->proto.fd_min, c->proto.fd_max, (x))) > =20 > +#define MAC_BROADCAST \ > + ((uint8_t [ETH_ALEN]){ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }) > #define MAC_ZERO ((uint8_t [ETH_ALEN]){ 0 }) > #define MAC_IS_ZERO(addr) (!memcmp((addr), MAC_ZERO, ETH_ALEN)) > =20 > --=20 > 2.47.3 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --y0HKT7lhPDsksxY6 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjKY0kACgkQzQJF27ox 2GfPBw//WWkc4g7MOHYPqErdAEepIrDiLAQ7jRziMYMAUUjF0P8bPi0gBK4Vmpr9 68koj0F/educQVmyLQVsecOQjwk4zc1GwziapICFVvAisr1cLGw+CsMsCb6Oxw8q E5+kg9gviHiFJWwl2LFytADfsPGEd+Dbxay12ats1ihKV8OWLS02Dk6MoWvfE5mg x9wRAUEcqxBAwFW7eruw8DNrslK/lstncY1XjWwEgz/TQQu8c0amePf8l8ndz1ha gPtnz3iQFdwbsOOOT2FKmn6uHkENliT55ccWlAD399A9Vn4w829U3mKPZVy187SB vfOMzlpTrJMAyjyVadCa2BGgBlJPjqUwFBDgRRTjUJ5pXOnU2ETZqVlfUofZF9o+ dnlJuzVaz4tYIqqCrZqTgCuh4adsT6heBKEnSn/gEt3C+vS3ck8tRWUUEyKu3fr8 aqOx0wES9lrC6K11JvaguYpCdfGtg4TAjohB25S6CbzklAgH14roE1u4t25wO6Ut g+IUZu5sZvTZZaFyAt1RyI6CNtw1Xagjs2iEwYbjYSbYQ3+w8mF7yKgMC4sfFKkU lXXNbewgJVNt1mftLphkQWkMd+mzN8E9pWUHWT2LbWCnnIPB7jlQQWFbcsG2GmN/ E/PVqklarjTnnEeCTaeBR2OaEbvnB1t1EfqcbcV9YwrGPjLrN4A= =cyJo -----END PGP SIGNATURE----- --y0HKT7lhPDsksxY6--