From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=Dg1xg0O2; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id BE86D5A06E2 for ; Wed, 17 Sep 2025 09:30:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758094201; bh=VA9z64T+Oyi5ah/XFxGZjeK2kgdxoZSINvIFU/eD9bI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dg1xg0O2qNusB2CfDqo6VSKMD05Pe3SWG51FQTsId7SSGnafdLsPDmmfa2obTA7x8 +ldXrWDG0fPC29AfoeexsahJ+zZivpBL7FjWKVrwPMAq6+kUNoo0w+MjIQhImbDwEo BV9WjR0WMSGoRCKvuO/70U+oV4fhSuq3+81WB70YJosslgLifYeR4tCjAqi5MwTixj fO867hfmalN4A7SGvM/juHENLMt+yvSOhWgLTHuRa3dU58JTvTYeTnQRrM4K1I309w 8xfKHKBXLpTpvSAlo4ldkmIN9Dm9M192hpMra9ODMJ8L/6gH9wJJpgzYaDF5t9VRz5 yXPl046PNH6vg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cRVls4syVz4wD4; Wed, 17 Sep 2025 17:30:01 +1000 (AEST) Date: Wed, 17 Sep 2025 17:29:43 +1000 From: David Gibson To: Volker Diels-Grabsch Subject: Re: [PATCH 3/5] Fix --no-icmp description and make it imply --no-ndp Message-ID: References: <20250916192209.3986375-1-v@njh.eu> <20250916192209.3986375-4-v@njh.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Z6C4gfQJKYX5dzp+" Content-Disposition: inline In-Reply-To: <20250916192209.3986375-4-v@njh.eu> Message-ID-Hash: SX4FLIR742MZ4IWZKR2UWJ27V2ENKHGS X-Message-ID-Hash: SX4FLIR742MZ4IWZKR2UWJ27V2ENKHGS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Z6C4gfQJKYX5dzp+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 16, 2025 at 09:21:14PM +0200, Volker Diels-Grabsch wrote: > Signed-off-by: Volker Diels-Grabsch Reviewed-by: David Gibson > --- > conf.c | 3 +++ > passt.1 | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index f47f48e..02e903b 100644 > --- a/conf.c > +++ b/conf.c > @@ -2067,6 +2067,9 @@ void conf(struct ctx *c, int argc, char **argv) > =20 > isolate_user(uid, gid, !netns_only, userns, c->mode); > =20 > + if (c->no_icmp) > + c->no_ndp =3D 1; > + > if (c->pasta_conf_ns) > c->no_ra =3D 1; > =20 > diff --git a/passt.1 b/passt.1 > index cef98b2..dd00b08 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -319,8 +319,8 @@ silently dropped. > =20 > .TP > .BR \-\-no-icmp > -Disable the ICMP/ICMPv6 echo handler. ICMP and ICMPv6 echo requests comi= ng from > -guest or target namespace will be silently dropped. > +Disable the ICMP/ICMPv6 protocol handler. ICMP and ICMPv6 requests comin= g from > +guest or target namespace will be silently dropped. Implies \fB--no-ndp\= fR. > =20 > .TP > .BR \-\-no-dhcp > --=20 > 2.47.3 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Z6C4gfQJKYX5dzp+ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjKY2YACgkQzQJF27ox 2GdKwA//U6zmtzjRvUVISHRxDa6eIotVnVIBspOCURgXhRsfIgGeX3jaTJqLi6hv r3IZ7YmViq33cMwB9AqFAbzQqsHf3l0UbdSVNUBdW6uQ9IS8mfdbvD+2/f5sKwX3 M3rZcQXyIXW7baE5pSHKXbL+JyVCnJc1YzotMEmpvHWoqGyZYifu6fnWOAoRemCq H0g9P0T8twR/FaGrtKznwAZvxyUlXVGIIlsgkiV+G+dWgOthBMCPXxznFtlyCOgv P4G4BhCGG4dFAMGaLoubCz2d2bdi42435Vv4POCHMcQ3RoOML5TF5CCCl5EUUsI3 Y1gyU0lcDEUkmJtp4Ez0eqiMUY695VKbVWPiZUaKk6+8X1nKdKbxtV5904Gj9ZPp EgedbQToY7cLhwT4aXHqrzBMiryAblwJ7nSUaOvXFr3X0UssRLP+G/ufRkS9zmfa w1n0GFucQTHj8kOZDXypD0XT9TeD0HyRvWMrnpQRcAAYRgKReO734hFxc5xS0StQ wWcPS7ION8WWhqXU1xnIY1+tI8YvYYCuHuGyABb+qPQoAS2DMeauUOQHsJEcKqIl f0oB6NbFhJ+rW0HXkUpIJuodXSQ1rQM76SJ6Xv2IeLvDzODqVWkhLj9hOveI5wVz BJQ4A9fVAP0iVe4QeKeMwaWtcvycZuWYjmw/km8eu+BuQBPjKEo= =U53u -----END PGP SIGNATURE----- --Z6C4gfQJKYX5dzp+--