From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=Nzbk7Gue; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 8C8B55A068E for ; Fri, 19 Sep 2025 03:45:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758246338; bh=P9IlPywQkorHIQ8zYfOpO2jAhYGn5AlM1IEIip394zU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nzbk7GuexAohKbaQj2Gqzi3fjEquTsuA1hnAvJrgjUeFFz2y50C/xOwEy82PTi8/E AY26og7Ygo6ieHJvLShmDJX79qmBnAelhylLz6423rN7IZLNVbUP3By/8VocZ0jBXz SsXh8u8OiOetbiZQsMxOYL1yR7oLlhsB2OIOJeUvWfhE1x5CXgPAM6o5vMAAn8ilKd VnHrHj0gTtnWG0qkK1miRDiXYCe/Jqfulk3XtC9kffdMvIJYmTFnx/CTO8mIhgGbH9 9ZXYXy1TZqxCiI8Gqm2LKg0UhXj2mcuUfKIW9Ed6iHMlfzQbj2nioLVKh8E97Gt09R aItKgftZlZVYw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cSb1Z1h7Jz4wCQ; Fri, 19 Sep 2025 11:45:38 +1000 (AEST) Date: Fri, 19 Sep 2025 11:45:32 +1000 From: David Gibson To: Volker Diels-Grabsch Subject: Re: [PATCH v6 1/5] Message-ID: References: <20250916192209.3986375-1-v@njh.eu> <20250917163242.34096a32@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ei5ukzrpXeBfrVTu" Content-Disposition: inline In-Reply-To: Message-ID-Hash: 2CLRZJQIAOC4NU7N4AA2BH666PWCUMUJ X-Message-ID-Hash: 2CLRZJQIAOC4NU7N4AA2BH666PWCUMUJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefano Brivio , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ei5ukzrpXeBfrVTu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 19, 2025 at 02:59:29AM +0200, Volker Diels-Grabsch wrote: > Stefano Brivio wrote: > > On Tue, 16 Sep 2025 21:21:11 +0200 > > Volker Diels-Grabsch wrote: > >=20 > > > This incorporates all feedback of v5, and the commits are > > > slightly reordered so the comment of the last commit makes > > > more sense. > >=20 > > Applied, thanks to sticking to this! I hope this will finally > > make the QEMU disconnect/reconnect behaviour robust enough. >=20 > As far as I can tell from my tests, locally as well as on production > systems, this is pretty much the case. >=20 > Thanks a lot for the opportunity to contribute some helpful > improvements to passt! >=20 > > A couple of notes for future changes: > >=20 > > - you can add this kind of message as cover letter instead, just > > git format-patch --cover-letter and git will format things as > > needed, and concatenate In-Reply-To: and References: email > > headers > >=20 > > - reporting the version number in every subject line might make > > reviewers' life marginally easier and it just takes a > > --subject-prefix=3D"PATCH v6" (in this case) or even something > > like -v6 argument to git format-patch > >=20 > > - carry Reviewed-by: tags if you don't... change the change. For > > example, here, 4/5 was already reviewed by David. I added the > > tag back (and will always do anyway) > >=20 > > ...in any case, those are very minor details that don't really > > cause me any trouble as a maintainer. >=20 > I believe these would be great additions to the upcoming > CONTRIBUTING.md, especially for people like myself who are used to > workflows like Gerrit or pull requests (a.k.a. merge requests) and had > no prior experience with the kernel-style email based workflow. CONTRIBUTING.md is now merged :). I'm sure it will want some revisions and extensions, but it's a start. > (And moreover, the interactive interface of "git send-email" is far > from self-explanatory and requires quite a lot of trial and error to > get everything right, and usage mistakes are mostly impossible to fix, > since the emails are then already sent.) You're not wrong. Fwiw, I've been pretty happy with git-publish [0] which handles some of this workflow. It may be more suitable for regular rather than occasional contributors, but it might be worth a look. Admittedly, I'm not the best to judge its usefulness to someone new to this, since I've been using the email workflow for 25+ years. [0] https://github.com/stefanha/git-publish --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --ei5ukzrpXeBfrVTu Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjMtbwACgkQzQJF27ox 2Gd40xAAp+64D6mWZbJ2MTDp4mgqWcZwybcI7D3npbYWFm6LGfcqUkSsEDjXpZhn HiQKt7jSB6pZbFt80jDA6A/OEj0dIfHBnnIVMGTj7yVOPGXo+LunKV+3TZEIBqHn CJlI34MnAedVYx3Teyb7g9+EhWNPKl1w3zlYbDS/Fdeo6cIDVxdRo4bZjHrhkEwM WwquK9u/bw3rZor95jlLaSNSJ7SQaEPL6RAU8LC2ed2tvRc+ooV/+q4gu17Gah44 HZMPXZj0i7mc/RXdB4oZ//gLGKRoYHwZ1I+CaOgu/ZBLBUMj4oqsw8NSZJbdeclw tNFwHdP0Vh9Hk+jZ0n+VmdpkGnvba/Drc8xtF65/g2f2dqAYW4Rq8wsyLt5JLmNn a3z5M9oeOs0pVUOoXEfLyItBoLd0G1MjLuLwNexUTzpblS1JpmVpPX79u49xEJH6 krr/soEeajGtnwVixK8YsdIPR//IArcuox0AVYKvVxlSsXG3Zdkag3JJFZGoLmlV 9PzS/Hf9xFC/15fwY0tZNgZV/5V/SHs7+O5XP3TwlDXBCEUFaSX2ftDBJ+fB5TSY GPYgdYFXCqyTfbRPd7rB//FSqg8KHuESdA8BVtaQL1W8z17FfDFwY9yB3oFq/d4F aT382BAnwSnlPKVPbNZ2iHXahMVANbhzmijenocZMmXkXJIUGG4= =VbXg -----END PGP SIGNATURE----- --ei5ukzrpXeBfrVTu--