Re: [PATCH 1/6] test: Convince make not to accidentally delete exetool

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

On Wed, Oct 01, 2025 at 07:51:57PM +1000, David Gibson wrote:
> Our exeter tests make use of exetool, a tool that's part of the exeter
> tree.  Both Yumei and I have seen cases where exetool is missing, despite
> it being from an external tree we shouldn't be touching.
> 
> I haven't pinned down the exact circumstances in which this happens, but I
> think this is occurring because the way the Makefile refers to it can make
> it look like an intermediate target that make may delete when interrupted.
> Mark it as .PRECIOUS to prevent that.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

This doesn't seem to be working, I'll try a different approach.

> ---
>  test/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/test/Makefile b/test/Makefile
> index 49388276..69987d0b 100644
> --- a/test/Makefile
> +++ b/test/Makefile
> @@ -81,6 +81,8 @@ pull-%: %
>  exeter:
>  	git clone https://gitlab.com/dgibson/exeter.git
>  
> +# Don't delete this, make, even though it looks like an intermediate target
> +.PRECIOUS: exeter/exetool/exetool
>  exeter/exetool/exetool: pull-exeter
>  
>  mbuto:
> -- 
> 2.51.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]