From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=PhI0Pwt4; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 16A465A0272 for ; Thu, 02 Oct 2025 06:50:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759380614; bh=UXEkgLAv49Ei3Jd4UjogPprJu31fskf3dzgrmh6yY+s=; h=Date:From:To:Subject:References:In-Reply-To:From; b=PhI0Pwt4IoHZiZtBGbdk+XBR70squ2Upiv/p+kUzMHjidVqmSvrLgtKo+yBtFFoUW Qbek2Ur2mUAMcGZYkPV6lFBdBVXa26Q9NS4DARVPu9xzVv1bSRg3eGsIYdzB6lcFgb knASTdMLbbkvaPkRer0baXb8Y38F1q5Jt8EQzA7p3UQD0RSPjSLoxeYdQ45592FVF3 TsP0LVgFhgOSGBbdL9oYJnMHpjAqu7v72LIsmCQjQnET+iZpyQ10ZE+soeNJQcFyoN EFZ+hTyfD+WCHtGlrU2AV4DVZoSHPIOlyO/qcsM8LWlBqQWuqsLMWl3SiUOnd3kyZ1 Az+wXk8QIkatg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ccfVZ4qPWz4wD8; Thu, 2 Oct 2025 14:50:14 +1000 (AEST) Date: Thu, 2 Oct 2025 13:26:59 +1000 From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: Re: [PATCH 1/6] test: Convince make not to accidentally delete exetool Message-ID: References: <20251001095202.3875003-1-david@gibson.dropbear.id.au> <20251001095202.3875003-2-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WwUxA54/8Cn4zFB6" Content-Disposition: inline In-Reply-To: <20251001095202.3875003-2-david@gibson.dropbear.id.au> Message-ID-Hash: TIKVANQA2Y2UOSBVHNO7XK3X4ONZRLYD X-Message-ID-Hash: TIKVANQA2Y2UOSBVHNO7XK3X4ONZRLYD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --WwUxA54/8Cn4zFB6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 01, 2025 at 07:51:57PM +1000, David Gibson wrote: > Our exeter tests make use of exetool, a tool that's part of the exeter > tree. Both Yumei and I have seen cases where exetool is missing, despite > it being from an external tree we shouldn't be touching. >=20 > I haven't pinned down the exact circumstances in which this happens, but I > think this is occurring because the way the Makefile refers to it can make > it look like an intermediate target that make may delete when interrupted. > Mark it as .PRECIOUS to prevent that. >=20 > Signed-off-by: David Gibson This doesn't seem to be working, I'll try a different approach. > --- > test/Makefile | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/test/Makefile b/test/Makefile > index 49388276..69987d0b 100644 > --- a/test/Makefile > +++ b/test/Makefile > @@ -81,6 +81,8 @@ pull-%: % > exeter: > git clone https://gitlab.com/dgibson/exeter.git > =20 > +# Don't delete this, make, even though it looks like an intermediate tar= get > +.PRECIOUS: exeter/exetool/exetool > exeter/exetool/exetool: pull-exeter > =20 > mbuto: > --=20 > 2.51.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --WwUxA54/8Cn4zFB6 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjd8PYACgkQzQJF27ox 2Gc8eg//WspI0OWoipOsXk7qT7QUL9DLU1ZxbGavtZf+x7xnPl2BthbD9UAF22Xx A3RiAwxaDuW4GzeCWt8z6nEWNxSaC4ztDS7gObAVPF2mJe3JCQy+NgohbuwKpY8H IWk0g+8eWbVKmcRFETve+WKuufOuitImk9rMebXJyzELqlf0PMjjyJ3rus1AyqmF 6wb0JFy7fZB8OsD/ohrQNRjY1MxRJjnQwm+bMwi346ZgkmGarJQ6NmAnuvnOAFHZ hbltS4nPoLtc9JakLEb/lkdxoFxBFHzG3+wc4NC9FTbhJINoD6ND8a05Iny0eDRp 3i35wP4xfT44Ej0JA7FnaALUOYrs8ylN94wIPjaegGitGtL5FQYsDzdIsY6JtTKu v0OeqUHGyD6KqD2d35NYqLfdXe/fgUX7qO3by2gwRUl0Vzthol21Qy89sOwo5JIj 809Qg4f+LR0sC2KyUsqlKmMJN37y097O7I2LWm9v3DbkvjM367V3+xIp6jd7CLiz fvti8JQd9tO3cOaQt/0QwRU0/QUvhPLcq447t5GnEMyC1H/PbtlNrm0ukrthUgRF NAb6vojSUeKLHXx6O47AfHQawxeOwYWBYFrr57w7pqF9VWN49b9Y40/ucqWtDG3u JMBnTM8JQcAHehkzvo4FbAtjfn7eanOUR0akwJ9JXlne2l6y1y0= =VrQP -----END PGP SIGNATURE----- --WwUxA54/8Cn4zFB6--